From owner-cvs-all Mon Jun 18 11:24:53 2001 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [206.40.252.115]) by hub.freebsd.org (Postfix) with ESMTP id 0D8EA37B401; Mon, 18 Jun 2001 11:24:50 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.3/8.11.1) id f5IIOnT95274; Mon, 18 Jun 2001 11:24:49 -0700 (PDT) (envelope-from obrien) Date: Mon, 18 Jun 2001 11:24:49 -0700 From: "David O'Brien" To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/fstat fstat.c Message-ID: <20010618112449.A95135@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <200106180629.f5I6TVs70841@freefall.freebsd.org> <20010618115221.D56404@sunbay.com> <20010618120130.G1713@ringworld.oblivion.bg> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010618120130.G1713@ringworld.oblivion.bg>; from roam@orbitel.bg on Mon, Jun 18, 2001 at 12:01:30PM +0300 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Jun 18, 2001 at 12:01:30PM +0300, Peter Pentchev wrote: > > And btw, no, I don't think it is worth it in this particular case > to separate functionality and whitespace changes. Even the untrained > eye can easily see that the first and third chunk are no-ops :) > If parts of it are NOPs, it should be a separate commit. Period. > BTW, do people feel that I should back this change out, and redo it > in two separate commits? No, the damage is done. Please follow established practices in the future. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message