From owner-cvs-all@FreeBSD.ORG  Sun Apr  4 17:00:22 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 478EC16A4CE; Sun,  4 Apr 2004 17:00:22 -0700 (PDT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3608543D3F; Sun,  4 Apr 2004 17:00:22 -0700 (PDT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id 2E8E45C7C3; Sun,  4 Apr 2004 17:00:22 -0700 (PDT)
Date: Sun, 4 Apr 2004 17:00:22 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: Nate Lawson <nate@root.org>
Message-ID: <20040405000022.GX26131@elvis.mu.org>
References: <20040402230239.23FA616A4F4@hub.freebsd.org>
	<20040403143811.H11430@root.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040403143811.H11430@root.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-src@FreeBSD.org
cc: Sam Leffler <sam@FreeBSD.org>
cc: cvs-all@FreeBSD.org
cc: src-committers@FreeBSD.org
Subject: Re: cvs commit: src/sys/net80211 ieee80211_node.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Apr 2004 00:00:22 -0000

* Nate Lawson <nate@root.org> [040403 13:39] wrote:
> On Fri, 2 Apr 2004, Sam Leffler wrote:
> > sam         2004/04/02 15:02:24 PST
> >
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/net80211         ieee80211_node.c
> >   Log:
> >   replace explicit malloc/free with MALLOC/FREE for portability
> >
> >   Obtained from:  madwifi
> >
> >   Revision  Changes    Path
> >   1.17      +5 -3      src/sys/net80211/ieee80211_node.c
> 
> Strange, sys/malloc.h says these are deprecated:
> 
> /*
>  * Deprecated macro versions of not-quite-malloc() and free().
>  */
> #define MALLOC(space, cast, size, type, flags) \
>         ((space) = (cast)malloc((u_long)(size), (type), (flags)))
> #define FREE(addr, type) free((addr), (type))

They were the prefered mechanism because of the formerly available
macros that would evaluate the malloc bucket to pull-from/release-to
in several cycles via constant folding.

In fact I still think the macros are a decent idea because we
might later find a cool optimization we can do via macros.



-- 
- Alfred Perlstein
- Research Engineering Development Inc.
- email: bright@mu.org cell: 408-480-4684