From owner-freebsd-hackers@FreeBSD.ORG Mon Apr 13 17:55:12 2009 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 67E58106566B; Mon, 13 Apr 2009 17:55:12 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 694318FC1F; Mon, 13 Apr 2009 17:55:11 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 4DF1646B2C; Mon, 13 Apr 2009 13:55:10 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 433638A051; Mon, 13 Apr 2009 13:54:50 -0400 (EDT) From: John Baldwin To: Sergey Babkin Date: Mon, 13 Apr 2009 12:56:44 -0400 User-Agent: KMail/1.9.7 References: <1366225354.253456.1238948619308.JavaMail.root@vms124.mailsrvcs.net> <200904070921.14294.jhb@freebsd.org> <49DBFA72.9E64AB4F@verizon.net> In-Reply-To: <49DBFA72.9E64AB4F@verizon.net> MIME-Version: 1.0 Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200904131256.44692.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 13 Apr 2009 13:54:50 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=0.1 required=4.2 tests=RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: freebsd-hackers@freebsd.org, Ivan Voras Subject: Re: Patch for MS Hyper V (virtualization) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Apr 2009 17:55:12 -0000 On Tuesday 07 April 2009 9:14:26 pm Sergey Babkin wrote: > John Baldwin wrote: > > > > On Monday 06 April 2009 11:12:33 pm Sergey Babkin wrote: > > > > Anyway, as far as I can tell, it's only the base register of > > > the simulated DEC21140 device that has this issue, so it's > > > quite possible that the bug is in that device's simulator. > > > > > > I've attached a modified patch that checks conservatively for this > > > precise situation, so it should not break compatibility with > > > anything else. I've tested it on Hyper-V. > > > > Can you test unmodified FreeBSD 8 on Hyper-V? It has an extra fix relative to > > 7 to disable decoding via the PCI command register while sizing BARs that may > > address this. > > 8.0 (February snapshot) seems to have the same issue. Ok. > I've also saved the log of writes that 7.1 does for this device: > > reg 10 val ec01 > reg 14 val febff000 > reg 18 val 0 > reg 1c val 0 > reg 20 val 0 > reg 24 val 0 > reg 30 val febe0000 > reg 4 val 117 > reg 3c val b > reg 3d val 1 > reg 3e val 14 > reg 3f val 28 > reg c val 8 > reg d val 40 > reg 9 val 0 > reg 8 val 20 > reg 10 val ec00 > reg 14 val febff000 > reg 4 val 117 > reg 4 val 117 > > I don't see any ffffffff values. Your printf() probably isn't in the right place. pci_add_map() uses PCIB_READ_CONFIG() directly and doesn't use pci_read_config(), so if your printf is in pci_read_config_method() in pci.c it won't see them. Try hooking the cfg operations in sys/amd64/pci/pci_cfgreg.c instead. -- John Baldwin