From owner-freebsd-bugs@freebsd.org Wed Dec 4 20:53:10 2019 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DD8DF1AECC1 for ; Wed, 4 Dec 2019 20:53:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 47SrfG5Zp5z4MHB for ; Wed, 4 Dec 2019 20:53:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id BF5BC1AECBE; Wed, 4 Dec 2019 20:53:10 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BF1B51AECBD for ; Wed, 4 Dec 2019 20:53:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47SrfG4bdZz4MH9 for ; Wed, 4 Dec 2019 20:53:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 66F9A62C1 for ; Wed, 4 Dec 2019 20:53:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id xB4KrA4N021819 for ; Wed, 4 Dec 2019 20:53:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id xB4KrAcq021818 for bugs@FreeBSD.org; Wed, 4 Dec 2019 20:53:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 242437] Jail rc script does not return non-0 exit code on problems Date: Wed, 04 Dec 2019 20:53:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 12.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: philipp@copythat.de X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Dec 2019 20:53:10 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D242437 Bug ID: 242437 Summary: Jail rc script does not return non-0 exit code on problems Product: Base System Version: 12.1-RELEASE Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: conf Assignee: bugs@FreeBSD.org Reporter: philipp@copythat.de Trying to start jails using "service jail start ". I found two types of failures that cause the /etc/rc.d/jail script to retur= n 0 after printing "cannot start jail" and not starting the jail. The two cases are:=20 1. An exec.prestart command fails 2. The named jail does not exist Examples: [root@kwik-e /etc]# service jail start lmcv6 Starting jails: cannot start jail "lmcv6":=20 ifconfig: BRDGADD epair4b: File exists jail: lmcv6: ifconfig bridge1 addm epair4b: failed . [root@kwik-e /etc]# echo $? 0 [root@kwik-e ~]# service jail start doesnotexist Starting jails: cannot start jail "doesnotexist":=20 jail: "doesnotexist" not found . [root@kwik-e ~]# echo $? 0 Looking at the code quickly it looks to me that no failures are handled with regards to the exit code of the script itself. Some logic might need to be defined to deal with partial failures when star= ting multiple or all jails. Returning 1 on anything except complete and utter success would also work for me. --=20 You are receiving this mail because: You are the assignee for the bug.=