From owner-freebsd-hackers@FreeBSD.ORG  Fri Dec 23 00:40:07 2005
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
X-Original-To: freebsd-hackers@freebsd.org
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4FB5616A41F;
	Fri, 23 Dec 2005 00:40:07 +0000 (GMT)
	(envelope-from dunstan@freebsd.czest.pl)
Received: from freebsd.czest.pl (freebsd.czest.pl [80.48.250.4])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9494D43D4C;
	Fri, 23 Dec 2005 00:40:06 +0000 (GMT)
	(envelope-from dunstan@freebsd.czest.pl)
Received: from freebsd.czest.pl (freebsd.czest.pl [80.48.250.4])
	by freebsd.czest.pl (8.12.10/8.12.9) with ESMTP id jBN0gnPx019204;
	Fri, 23 Dec 2005 00:42:49 GMT
	(envelope-from dunstan@freebsd.czest.pl)
Received: (from dunstan@localhost)
	by freebsd.czest.pl (8.13.4/8.12.9/Submit) id jBN0gnwD019203;
	Fri, 23 Dec 2005 00:42:49 GMT (envelope-from dunstan)
Date: Fri, 23 Dec 2005 00:42:48 +0000
From: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>
To: John Baldwin <jhb@freebsd.org>
Message-ID: <20051223004248.GA19050@FreeBSD.czest.pl>
References: <20051215223745.GA37768@FreeBSD.czest.pl>
	<20051216091057.GQ77268@cirb503493.alcatel.com.au>
	<200512161114.14398.jhb@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
In-Reply-To: <200512161114.14398.jhb@freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: freebsd-hackers@freebsd.org, phk@freebsd.org,
	Peter Jeremy <PeterJeremy@optushome.com.au>
Subject: Re: [CALL FOR TESTERS] New system call: abort2()
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Dec 2005 00:40:07 -0000

On Fri, Dec 16, 2005 at 11:14:12AM -0500, John Baldwin wrote:
> On Friday 16 December 2005 04:10 am, Peter Jeremy wrote:
> > On Thu, 2005-Dec-15 22:37:45 +0000, Wojciech A. Koszek wrote:
> > >	abort2(const char *why, int nargs, void **args);
> > >
> > >"why" is reason of program abort, "nargs" is number of arguments
> > >passed in "args". Both "why" and "args" (with "%p" format) will be
> > >printed via log(9). Sample output:
> > >[..]
> > >pid <3004> <abort2> abort2: ABORT2 <arg0:0x62612f2e>
> > >pid <3019> <abort2> abort2: invalid argument
> > >[..]
[..]
> 
> Agreed.  Also, copyinstr() can provide a better interface for copying the why 
> string in.  Also, the PROC LOCK isn't needed for reading the static p_pid and 
> p_comm fields of struct proc.  Also, I second the other comments of do { } 
> while(0) vs goto.  Many existing syscalls use 'goto out;' for error handling, 
> and I think that is one of the very few cases when goto is useful and not 
> harmful.

Updated patch is here:

http://freebsd.czest.pl/dunstan/FreeBSD/abort2/abort2.3.patch

If I have to change something, let me know. Once again -- comments are
welcome.

-- 
* Wojciech A. Koszek && dunstan@FreeBSD.czest.pl