From owner-freebsd-bugs  Wed Mar 10  8:50:32 1999
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 45E1A15431
	for <freebsd-bugs@FreeBSD.org>; Wed, 10 Mar 1999 08:50:14 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.2/8.9.2) id IAA61294;
	Wed, 10 Mar 1999 08:50:00 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from point.osg.gov.bc.ca (point.osg.gov.bc.ca [142.32.102.44])
	by hub.freebsd.org (Postfix) with ESMTP id A6F0C1532C
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 10 Mar 1999 08:48:02 -0800 (PST)
	(envelope-from cy@cschuber.net.gov.bc.ca)
Received: (from daemon@localhost)
	by point.osg.gov.bc.ca (8.9.1/8.8.8) id IAA14149
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 10 Mar 1999 08:47:43 -0800
Received: from cschuber.net.gov.bc.ca(142.31.240.113), claiming to be "cwsys.cwsent.com"
 via SMTP by point.osg.gov.bc.ca, id smtpda14146; Wed Mar 10 08:47:28 1999
Received: (from cy@localhost)
	by cwsys.cwsent.com (8.9.3/8.9.1) id IAA17487;
	Wed, 10 Mar 1999 08:47:25 -0800 (PST)
Message-Id: <199903101647.IAA17487@cwsys.cwsent.com>
Date: Wed, 10 Mar 1999 08:47:25 -0800 (PST)
From: Cy Schubert <cy@cschuber.net.gov.bc.ca>
Reply-To: cschuber@uumail.gov.bc.ca
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: kern/10528: MFS problem, syncing filesystems... giving up
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         10528
>Category:       kern
>Synopsis:       MFS fails to die when system shut down
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 10 08:50:00 PST 1999
>Closed-Date:
>Last-Modified:
>Originator:     Cy Schubert
>Release:        FreeBSD 3.1-RELEASE i386
>Organization:
ITSD, Province of BC
>Environment:

	FreeBSD cwsys 3.1-RELEASE FreeBSD 3.1-RELEASE #0: Wed Mar 10 06:26:02 PST 1999     root@cwsys:/usr/src/sys/compile/CWSYS  i386

>Description:

	When 3.1.0 is shut down, message "syncing filesystems... giving
	up" is displayed and all filesystems are dirty when system is
	subsequently rebooted.  It appears that the difference (that
	is causing this problem) is that the P_SYSTEM flag is set
	for MFS when it first starts causing it to be unkillable by
	the system unless it is specifically listed in a kill
	command or via a umount.

>How-To-Repeat:

	Mount an MFS filesystem and use it, then reboot.  There need
	to be dirty buffers that need to be synced to MFS to exploit
	this bug, IMO 80% of the time.

>Fix:
	

--- src/sys/ufs/mfs/mfs_vfsops.c.orig	Thu Dec 31 20:14:11 1998
+++ src/sys/ufs/mfs/mfs_vfsops.c	Wed Mar 10 07:58:24 1999
@@ -423,8 +423,10 @@
 			if (dounmount(mp, 0, p) != 0)
 				CLRSIG(p, CURSIG(p));	/* try sleep again.. */
 		}
-		else if (tsleep((caddr_t)vp, mfs_pri, "mfsidl", 0))
+		else if (tsleep((caddr_t)vp, mfs_pri, "mfsidl", 0)) {
 			gotsig++;	/* try to unmount in next pass */
+			curproc->p_flag &= ~P_SYSTEM;
+		}
 	}
 	return (0);
 }

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message