From owner-freebsd-rc@FreeBSD.ORG Sat Nov 17 23:10:01 2012 Return-Path: Delivered-To: freebsd-rc@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 70B48A89 for ; Sat, 17 Nov 2012 23:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 3E0D08FC13 for ; Sat, 17 Nov 2012 23:10:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qAHNA1V6074608 for ; Sat, 17 Nov 2012 23:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qAHNA1ex074607; Sat, 17 Nov 2012 23:10:01 GMT (envelope-from gnats) Date: Sat, 17 Nov 2012 23:10:01 GMT Message-Id: <201211172310.qAHNA1ex074607@freefall.freebsd.org> To: freebsd-rc@FreeBSD.org Cc: From: Hiroki Sato Subject: Re: bin/165477: [rc] dhclient is run twice X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Hiroki Sato List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Nov 2012 23:10:01 -0000 The following reply was made to PR bin/165477; it has been noted by GNATS. From: Hiroki Sato To: crees@FreeBSD.org Cc: wblock@FreeBSD.org, freebsd-rc@FreeBSD.org, bug-followup@FreeBSD.org Subject: Re: bin/165477: [rc] dhclient is run twice Date: Sun, 18 Nov 2012 07:59:56 +0900 (JST) ----Security_Multipart0(Sun_Nov_18_07_59_56_2012_823)-- Content-Type: Multipart/Mixed; boundary="--Next_Part(Sun_Nov_18_07_59_56_2012_546)--" Content-Transfer-Encoding: 7bit ----Next_Part(Sun_Nov_18_07_59_56_2012_546)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit crees@freebsd.org wrote in <201211021111.qA2BBHEi008211@freefall.freebsd.org>: cr> Synopsis: [rc] dhclient is run twice cr> cr> State-Changed-From-To: open->feedback cr> State-Changed-By: crees cr> State-Changed-When: Fri Nov 2 11:11:17 UTC 2012 cr> State-Changed-Why: cr> Please try out the patch at cr> http://www.bayofrum.net/~crees/patches/165477.diff to devd.conf. It cr> does the "right thing", so let me know if it stops your problem. I think it is safe to remove the warning message when rc_quiet=YES. What do you think about the attached patch? -- Hiroki ----Next_Part(Sun_Nov_18_07_59_56_2012_546)-- Content-Type: Text/X-Patch; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="rc.subr_quiet_20121118-1.diff" Index: etc/rc.subr =================================================================== --- etc/rc.subr (revision 243184) +++ etc/rc.subr (working copy) @@ -704,7 +704,9 @@ start) if [ -z "$rc_fast" -a -n "$rc_pid" ]; then - echo 1>&2 "${name} already running? (pid=$rc_pid)." + if [ ! -z "$rc_quiet" ]; then + echo 1>&2 "${name} already running? (pid=$rc_pid)." + fi return 1 fi ----Next_Part(Sun_Nov_18_07_59_56_2012_546)---- ----Security_Multipart0(Sun_Nov_18_07_59_56_2012_823)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAlCoFuwACgkQTyzT2CeTzy1usgCgmqzn4/7Yhr0+fwxOPHqOXW07 FzUAoLQ/xwkyWXICEt8ptmJZrTq6icRA =etD7 -----END PGP SIGNATURE----- ----Security_Multipart0(Sun_Nov_18_07_59_56_2012_823)----