From owner-svn-ports-all@FreeBSD.ORG Fri Jun 14 15:00:43 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 957786DB; Fri, 14 Jun 2013 15:00:43 +0000 (UTC) (envelope-from william88@gmail.com) Received: from mail-la0-x22f.google.com (mail-la0-x22f.google.com [IPv6:2a00:1450:4010:c03::22f]) by mx1.freebsd.org (Postfix) with ESMTP id EB94713C8; Fri, 14 Jun 2013 15:00:41 +0000 (UTC) Received: by mail-la0-f47.google.com with SMTP id fe20so627195lab.34 for ; Fri, 14 Jun 2013 08:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Yaej0s5ci8frgy8D1E5VOoseM7LnbDCcK2GrWpQbQSI=; b=Gpy2NEhb4tSD15NXi6EmpliUIjPIXhl5thOaPZEb15KFnd1lV6GbLR2tob3iQo63PO S/bCYUYRTH+OX0W2JNv9FLS3YW24uHdDkuqk+y1WePPNQdb/YZQ32GYCW4YH8LxJ+yaW +yYHkLeyTxBIaso+qvUqvB/yS9lV5gXt2tPqTNNKkftY2z4WtTM4wOyeOOHxAK+vsaqz J+DII9t4SGDv8jjMVkEgihGoEK3OW2t29WcwSvpyUrDQOfma7bDEKSnUp9dHHSKtadhQ L/vPDbw/8CrhLPEUD8fQ62YS3uOYLn+ejtS9vuW0eYVF2LQ4/7LHAd4kTypo/UepZWqs Ch+Q== MIME-Version: 1.0 X-Received: by 10.152.44.170 with SMTP id f10mr1352054lam.68.1371222040821; Fri, 14 Jun 2013 08:00:40 -0700 (PDT) Received: by 10.114.91.202 with HTTP; Fri, 14 Jun 2013 08:00:40 -0700 (PDT) In-Reply-To: References: <201306131905.r5DJ5Scv074032@svn.freebsd.org> <20130614065523.GA98995@FreeBSD.org> Date: Fri, 14 Jun 2013 12:00:40 -0300 Message-ID: Subject: Re: svn commit: r320832 - head/net-mgmt/bandwidthd From: William Grzybowski To: Sunpoet Po-Chuan Hsieh Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev , Eitan Adler , svn-ports-all@freebsd.org, William Grzybowski , ports-committers X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jun 2013 15:00:43 -0000 On Fri, Jun 14, 2013 at 11:56 AM, Sunpoet Po-Chuan Hsieh wrote: > Try this (cited from lang/v8/Makefile) > > .if ${CC:T:Mclang} == "clang" || ${CXX:T:Mclang++} == "clang++" || > ${OSVERSION} >= 1000024 > ... > .endif That won't work, CC = "cc" in 10-CURRENT. One should use "cc -v" + grep to find out whether it is clang or cc. But I guess you're missing the point, there isn't a single issue here. All is resolved. Thanks > On Fri, Jun 14, 2013 at 2:55 PM, Alexey Dokuchaev wrote: >> >> On Thu, Jun 13, 2013 at 11:18:28PM +0200, Eitan Adler wrote: >> > On Thu, Jun 13, 2013 at 9:05 PM, William Grzybowski >> > wrote: >> > >> > > -.if ${CC} == "clang" >> > >> > Thank you for changing this. FWIW if you *do* need to detect clang >> > this check is incorrect. >> > >> > The idiom ${CC:T:Mclang} == "clang") is required in order to allow >> > absolute paths, etc. >> >> Well, these checks are obsolete on -CURRENT where Clang is installed as >> default compiler (cc). >> >> ./danfe > > > > > -- > Sunpoet Po-Chuan Hsieh > 4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B > http://people.FreeBSD.org/~sunpoet/pgpkeys.txt -- William Grzybowski ------------------------------------------ Curitiba/PR - Brasil