From owner-freebsd-arch@FreeBSD.ORG  Wed Dec 22 01:01:47 2004
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5A0C816A4CE
	for <arch@FreeBSD.org>; Wed, 22 Dec 2004 01:01:47 +0000 (GMT)
Received: from blackwater.lemis.com (wantadilla.lemis.com [192.109.197.135])
	by mx1.FreeBSD.org (Postfix) with ESMTP id ED9B143D1D
	for <arch@FreeBSD.org>; Wed, 22 Dec 2004 01:01:45 +0000 (GMT)
	(envelope-from grog@lemis.com)
Received: by blackwater.lemis.com (Postfix, from userid 1004)
	id 78E158567D; Wed, 22 Dec 2004 11:31:43 +1030 (CST)
Date: Wed, 22 Dec 2004 11:31:43 +1030
From: Greg 'groggy' Lehey <grog@FreeBSD.org>
To: FreeBSD Architecture Mailing List <arch@FreeBSD.org>
Message-ID: <20041222010143.GS53357@wantadilla.lemis.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="ceuyUbi+oA5bUa/n"
Content-Disposition: inline
User-Agent: Mutt/1.4.2.1i
Organization: The FreeBSD Project
Phone: +61-8-8388-8286
Fax: +61-8-8388-8725
Mobile: +61-418-838-708
WWW-Home-Page: http://www.FreeBSD.org/
X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F  09AC 22E6 F290 507A 4223
Subject: Header files with enums instead of defines?
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussion related to FreeBSD architecture
	<freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Dec 2004 01:01:47 -0000


--ceuyUbi+oA5bUa/n
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Has anybody thought about replacing #defines with enums in header
files?  It would make debugging a whole lot easier.  Foe example, I'm
currently looking at a debug printout which contains:

  xerrno =3D 17,=20

To find out what that means, I need to go to
/usr/src/include/sys/errno.h and look for 17.  I find:

#define	EEXIST		17		/* File exists */

If we were to change this to=20

enum EEXIST =3D 17;	                /* File exists */

I'd then be able to see:

  xerrno =3D EEXIST,=20

That makes debugging a whole lot easier.  About the only down side I
can see is that you can't #undef an enum.  Is this a big deal?

Greg
--
See complete headers for address and phone numbers.

--ceuyUbi+oA5bUa/n
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)

iD8DBQFByMd3IubykFB6QiMRAsqsAKCdn6bk1DLHe42IG/A60WA0zsb2zwCgtBzs
EKAabKQs9Be0pFp64FF86hM=
=ky4I
-----END PGP SIGNATURE-----

--ceuyUbi+oA5bUa/n--