From owner-svn-src-all@FreeBSD.ORG Mon Feb 16 03:37:00 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A01B7BEC; Mon, 16 Feb 2015 03:37:00 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 24D609E; Mon, 16 Feb 2015 03:36:59 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t1G3auQp047705 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 16 Feb 2015 06:36:56 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t1G3autc047704; Mon, 16 Feb 2015 06:36:56 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 16 Feb 2015 06:36:56 +0300 From: Gleb Smirnoff To: "Bjoern A. Zeeb" Subject: Re: svn commit: r278828 - head/sys/netinet6 Message-ID: <20150216033656.GD15484@FreeBSD.org> References: <201502160112.t1G1CKd0074570@svn.freebsd.org> <20150216013000.GB15484@FreeBSD.org> <8750BD23-1384-4065-8368-C332F6683814@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8750BD23-1384-4065-8368-C332F6683814@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 03:37:00 -0000 On Mon, Feb 16, 2015 at 01:34:09AM +0000, Bjoern A. Zeeb wrote: B> B> > On 16 Feb 2015, at 01:30 , Gleb Smirnoff wrote: B> > B> > On Mon, Feb 16, 2015 at 01:25:05AM +0000, Bjoern A. Zeeb wrote: B> > B> B> > B> > On 16 Feb 2015, at 01:12 , Gleb Smirnoff wrote: B> > B> > B> > B> > Author: glebius B> > B> > Date: Mon Feb 16 01:12:20 2015 B> > B> > New Revision: 278828 B> > B> > URL: https://svnweb.freebsd.org/changeset/base/278828 B> > B> > B> > B> > Log: B> > B> > Factor out ip6_deletefraghdr() function, to be shared between IPv6 B> > B> > stack and pf(4). B> > B> > B> > B> > Submitted by: Kristof Provost B> > B> > Reviewed by: ae B> > B> > Differential Revision: D1764 B> > B> > B> > B> > Modified: B> > B> > head/sys/netinet6/frag6.c B> > B> > head/sys/netinet6/ip6_output.c B> > B> B> > B> Why did it have to move file? B> B> But the new function is in ip6_output and the consumer stays in frag6 and will be in pf? So the new function moved to a different file without consumer rather than just on top of the old function? Keep code logically together seems to make more sense to me. What am I missing? You are right. I somehow misread it as function being in frag6.c and consumer in ip6_output.c. Will fix. -- Totus tuus, Glebius.