From owner-cvs-all@FreeBSD.ORG Tue Aug 16 09:01:53 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E342716A41F; Tue, 16 Aug 2005 09:01:53 +0000 (GMT) (envelope-from gavin.atkinson@ury.york.ac.uk) Received: from mail-gw0.york.ac.uk (mail-gw0.york.ac.uk [144.32.128.245]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3C35943D46; Tue, 16 Aug 2005 09:01:52 +0000 (GMT) (envelope-from gavin.atkinson@ury.york.ac.uk) Received: from buffy.york.ac.uk (buffy-128.york.ac.uk [144.32.128.160]) by mail-gw0.york.ac.uk (8.12.10/8.12.10) with ESMTP id j7G91l7i019184; Tue, 16 Aug 2005 10:01:47 +0100 (BST) Received: from buffy.york.ac.uk (localhost [127.0.0.1]) by buffy.york.ac.uk (8.13.3/8.13.4) with ESMTP id j7G91lMe002572; Tue, 16 Aug 2005 10:01:47 +0100 (BST) (envelope-from gavin.atkinson@ury.york.ac.uk) Received: (from ga9@localhost) by buffy.york.ac.uk (8.13.3/8.13.4/Submit) id j7G91l2r002571; Tue, 16 Aug 2005 10:01:47 +0100 (BST) (envelope-from gavin.atkinson@ury.york.ac.uk) X-Authentication-Warning: buffy.york.ac.uk: ga9 set sender to gavin.atkinson@ury.york.ac.uk using -f From: Gavin Atkinson To: Brian Fundakowski Feldman , Pawel Jakub Dawidek In-Reply-To: <20050816081644.GA3944@garage.freebsd.pl> References: <200508120005.j7C05ARc090857@repoman.freebsd.org> <20050815053757.GB2660@green.homeunix.org> <20050815070033.GA8368@garage.freebsd.pl> <20050815125814.GC2660@green.homeunix.org> <20050816081644.GA3944@garage.freebsd.pl> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Tue, 16 Aug 2005 10:01:46 +0100 Message-Id: <1124182906.2492.4.camel@buffy.york.ac.uk> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 FreeBSD GNOME Team Port X-York-MailScanner: Found to be clean X-York-MailScanner-From: gavin.atkinson@ury.york.ac.uk Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/geom/label g_label.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Aug 2005 09:01:54 -0000 On Tue, 2005-08-16 at 10:16 +0200, Pawel Jakub Dawidek wrote: > On Mon, Aug 15, 2005 at 08:58:14AM -0400, Brian Fundakowski Feldman wrote: > +> > +> Why would we want to prevent the usage of a specific directory structure > +> > +> to represent GEOM's namespace, if that's what the administrator wants? > +> > > +> > If the label name is 'foo/bar' it doesn't seems right to create 'foo' > +> > directory and provider 'bar' inside. The label could be also '../random' > +> > or something like this and I want to save administrator/user nasty surprises > +> > when he inserts some random CD. > +> > +> I like the idea of rejecting the latter, but what is the harm of the first > +> case? If I call something "foo/bar", I'll be surprised to find out that > +> it's located at /dev/foo_bar... my preference would be for the name to be > +> rejected completely instead of remapped, if a '/' is to not be allowed, > +> but that's my own. > > # cd /dev/foo > # rm/anything bar > > There was no label 'bar', right. Anyway. Instead of rejecting labels with > '/' I can print a warning on the console that a bit different label will be > used. What do you say? FWIW, I would prefer to see this backed out, or at least not MFC'd. I'm using labels containing slashes as a way to split a large number of devices up in /dev, and MFCing this would presumably break my setup. As far as I can tell, if somebody has used a "/" in a label, then that was an administrative decision, and if possible we should obey that. Is there any technical reason why a "/" cannot be allowed? I do agree that filtering out any occurances of "../" is a good idea. Gavin