From owner-svn-src-user@FreeBSD.ORG Sat May 16 08:27:23 2009 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B0B8E1065673; Sat, 16 May 2009 08:27:23 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 9EDE88FC1A; Sat, 16 May 2009 08:27:23 +0000 (UTC) (envelope-from kmacy@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n4G8RNMu049723; Sat, 16 May 2009 08:27:23 GMT (envelope-from kmacy@svn.freebsd.org) Received: (from kmacy@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n4G8RNBP049722; Sat, 16 May 2009 08:27:23 GMT (envelope-from kmacy@svn.freebsd.org) Message-Id: <200905160827.n4G8RNBP049722@svn.freebsd.org> From: Kip Macy Date: Sat, 16 May 2009 08:27:23 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r192192 - user/kmacy/ZFS_MFC/sys/cddl/contrib/opensolaris/uts/common/fs/zfs X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 May 2009 08:27:23 -0000 Author: kmacy Date: Sat May 16 08:27:23 2009 New Revision: 192192 URL: http://svn.freebsd.org/changeset/base/192192 Log: don't assume snapshot is mounted on the control directory Modified: user/kmacy/ZFS_MFC/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c Modified: user/kmacy/ZFS_MFC/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c ============================================================================== --- user/kmacy/ZFS_MFC/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c Sat May 16 06:57:24 2009 (r192191) +++ user/kmacy/ZFS_MFC/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vfsops.c Sat May 16 08:27:23 2009 (r192192) @@ -1078,14 +1078,11 @@ zfs_umount(vfs_t *vfsp, int fflag, kthre if (zfsvfs->z_issnap) { vnode_t *svp = vfsp->mnt_vnodecovered; -#if 0 /* - * I believe that this is incorrect for the - * case of manually mounted snapshots + * We don't need an extra vn_rele if this is a manual snapshot mount */ - ASSERT(svp->v_count == 2); -#endif - VN_RELE(svp); + if (svp->v_count == 2) + VN_RELE(svp); } zfs_freevfs(vfsp);