From owner-svn-ports-head@freebsd.org  Fri Nov 23 12:48:45 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9F6D5114620E;
 Fri, 23 Nov 2018 12:48:45 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4616D8768F;
 Fri, 23 Nov 2018 12:48:45 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 3630119E00; Fri, 23 Nov 2018 12:48:45 +0000 (UTC)
Date: Fri, 23 Nov 2018 12:48:45 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: Mathieu Arnold <mat@freebsd.org>
Cc: Dmitry Marakasov <amdmi3@amdmi3.ru>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r485586 - head/java/netty
Message-ID: <20181123124845.GA50746@FreeBSD.org>
References: <201811220930.wAM9URj7056367@repo.freebsd.org>
 <20181122095930.fnfd4gpowkqehznp@atuin.in.mat.cc>
 <20181122125524.GA37389@hades.panopticon>
 <20181122161928.md57g2b2y7ctvkdb@atuin.in.mat.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181122161928.md57g2b2y7ctvkdb@atuin.in.mat.cc>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-Rspamd-Queue-Id: 4616D8768F
X-Spamd-Result: default: False [2.02 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 NEURAL_SPAM_SHORT(0.31)[0.308,0];
 NEURAL_SPAM_MEDIUM(0.91)[0.907,0];
 NEURAL_SPAM_LONG(0.81)[0.809,0];
 ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US]
X-Rspamd-Server: mx1.freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Nov 2018 12:48:45 -0000

On Thu, Nov 22, 2018 at 05:19:28PM +0100, Mathieu Arnold wrote:
> On Thu, Nov 22, 2018 at 03:55:24PM +0300, Dmitry Marakasov wrote:
> > * Mathieu Arnold (mat@FreeBSD.org) wrote:
> > > > -PLIST_FILES=	%%JAVAJARDIR%%/netty-${PORTVERSION}.jar \
> > > > -		%%JAVAJARDIR%%/netty.jar
> > > > +PLIST_FILES=	${JAVAJARDIR:S,^${PREFIX}/,,}/netty-${PORTVERSION}.jar \
> > > > +		${JAVAJARDIR:S,^${PREFIX}/,,}/netty.jar
> > > 
> > > This seems overly complicated.  What is wrong with having just
> > > ${JAAAVJARDIR}?
> > 
> > It contains absolute path. I've assumed we don't use these in the plist.
> 
> Paths in the PLIST are either relative to PREFIX or absolute.  If a path
> is absolute and starts with PREFIX, it is just fine.

Absolute paths, however, look ugly in PLIST, and generally do not sound
like a good idea (e.g., how well do they align with relocatable packages)?

./danfe