Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 06 Apr 2022 15:28:39 +0000
From:      bugzilla-noreply@freebsd.org
To:        desktop@FreeBSD.org
Subject:   maintainer-feedback requested: [Bug 263094] textproc/libxml2: incorrect LIBXML_VERSION_STRING in 2.9.13
Message-ID:  <bug-263094-39348-rkMeX3iSoD@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-263094-39348@https.bugs.freebsd.org/bugzilla/>
References:  <bug-263094-39348@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help 
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-desktop (Team)
<desktop@FreeBSD.org> for maintainer-feedback:
Bug 263094: textproc/libxml2: incorrect LIBXML_VERSION_STRING in 2.9.13
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263094



--- Description ---
On FreeBSD 13, the `libxml2-2.9.13` package has an unexpected value in the
`xmlParserVersion` global variable.

Expected: "20913"

Actual: "209013" (note the additional "0" between the "9" and "13").

For comparison, in the `libxml2-2.9.12` package this value was correctly se=
t to
"20912".

Looking at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262288 this
appears to be happening because of this diff:

```
 /**
  * LIBXML_VERSION:
  *
  * the version number: 1.2.3 value is 10203
  */
-#define LIBXML_VERSION 20912
+#define LIBXML_VERSION 209013

 /**
  * LIBXML_VERSION_STRING:
  *
  * the version number string, 1.2.3 value is "10203"
  */
-#define LIBXML_VERSION_STRING "20912"
+#define LIBXML_VERSION_STRING "209013"
```

(see https://bz-attachments.freebsd.org/attachment.cgi?id=3D232326 for the =
full
diff)

I'm not sure why this has happened, but it's not uncommon for downstream us=
ers
of libxml2 to sanity-check this string to make sure the version dynamically
loaded is the same version that was compiled. See
https://github.com/sparklemotion/nokogiri/issues/2506 for an example.

I'd like to suggest that these strings should be set to "20913" in the next
release of the package.

Thank you!

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-263094-39348-rkMeX3iSoD>