From nobody Fri Feb 10 15:28:09 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PCyL32TKdz3ncgS; Fri, 10 Feb 2023 15:28:11 +0000 (UTC) (envelope-from mhorne@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PCyL31RgPz4Q0f; Fri, 10 Feb 2023 15:28:11 +0000 (UTC) (envelope-from mhorne@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676042891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gClgrssH9bYHkx0eu5eznQegeGHjfzSgPH1COHPCxRc=; b=gfuEPEIeEBqw2ncHXMX+iU7n9w/DBQ4aF/TH1F8c/5nzj2Q8Mg7wwhtZTgTZ/lmWEGYLor azoW4dp4ITqX7QCxF8+/R19eLth2mIXXaIWnUwgSQ5SjoywjwJ7cxaZ31nKOhKUZnACAyV XYqgK44d36e69SoCVJRsQ5gsfPbFCSUay585lbhHrsMk8v3w61CZiDbKpXVBzh+I1+urFs oVRURwKd83+WDgpK8OoI4sqq1zeHmiP6LXKP41Nq6qzEZkLyE4tPWlOQnk0Yuzs41Ma6vG 1EgQ+gWL39MZ0CQqBKWegHYTTUT4Zr6rx9jJ29XJq0NQlznyK/6bRmula5ZZdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676042891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gClgrssH9bYHkx0eu5eznQegeGHjfzSgPH1COHPCxRc=; b=FlTWMuGy4TPbMgCbjmGQfdcnHQKEEc6s/hMBg8g0oeT5pVUzMFeGEPhrPuVFFiL9C4ahkj FyY3Z9MWfsBFkw6zkXB3yCwX72yiDkTHFCW/41RU8sMMlMVkKBGzVgZsiRLye/gk4k0cDN cgrXaArJPB8+H6W/yNGIWtZQhSD7z1VQC1r4YzOLpzj1VZPAxnvGufXFNXFmIEjsP3FGu6 4MqkzrRu0DJZWk0VESlYgjOl8/vC1NRSdPS0tw7i0cEVfUzlFWR+w4kCOiKec4fmH/jTX3 0k06f4bPMIuztqlFYb7nccP5dfJgxToPG8K9Zs6VXz85BvXsXruIF47T2Uc71Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676042891; a=rsa-sha256; cv=none; b=ei1H4SgiW3b/JPHshm4uThzIbCEQ0FdnQalY7JKu6YaC7ze6SSgkRxffW/1TUm8BcFkwqO YrC43ZiBYNmwHG9x08Cq9mF4x8zes9p6f3Ss0RCz14yHfz+O0OZVZ9oPZEmq7KiBiVbQbP AnqouGCfIl/xsCmM7JCxGqcfcwGiOndv0KAf+Tjc2M4zkxegy/+ttrdnTauc89SDkFfzXZ QZdFNAEytuHlwr/sMAMWzxgqNvwckrLaeH3ADDXiN/7yIvC9Hqx/LVnZNEkq4aENL/OY00 ZZCz6Jp5Axe8iVIPFIM81j2RZjazQVeDawejKkB1wPbWTt7CeeXDV6ZvnQ2/Zg== Received: from [192.168.1.151] (host-173-212-76-127.public.eastlink.ca [173.212.76.127]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mhorne) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PCyL25hT4ztqx; Fri, 10 Feb 2023 15:28:10 +0000 (UTC) (envelope-from mhorne@freebsd.org) Message-ID: <69b2594c-6332-5169-50ec-de35fcce0fb6@freebsd.org> Date: Fri, 10 Feb 2023 11:28:09 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: git: f9bdaab95ec4 - main - ofwbus: remove handling of resources from ofwbus To: John Baldwin , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202302082052.318KqNUL052449@gitrepo.freebsd.org> <195e5cd0-e2cf-14d4-07d4-f368ab1a5f59@FreeBSD.org> Content-Language: en-CA From: Mitchell Horne In-Reply-To: <195e5cd0-e2cf-14d4-07d4-f368ab1a5f59@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 2/9/23 13:42, John Baldwin wrote: > On 2/8/23 12:52 PM, Mitchell Horne wrote: >> The branch main has been updated by mhorne: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=f9bdaab95ec469738fbfc1f0edd3e8c744b7f71f >> >> commit f9bdaab95ec469738fbfc1f0edd3e8c744b7f71f >> Author:     Elliott Mitchell >> AuthorDate: 2023-02-08 20:17:03 +0000 >> Commit:     Mitchell Horne >> CommitDate: 2023-02-08 20:50:46 +0000 >> >>      ofwbus: remove handling of resources from ofwbus >>      The architecture nexus should handle allocation and release of >> memory and >>      interrupts. This is to ensure that system-wide resources such as >> these >>      are available to all devices, not just children of ofwbus0. >>      On powerpc this moves the ownership of these resources up one level, >>      from ofwbus0 to nexus0. Other architectures already have the >> required >>      logic in their nexus implementation, so this eliminates the >> duplication >>      of resources. An implementation of nexus_adjust_resource() is >> added for >>      arm, arm64, and riscv. >>      As noted by ian@ in the review, resource handling was the main >> bit of >>      logic distinguishing ofwbus from simplebus. With some attention to >>      detail, it should be possible to merge the two in the future. >>      Co-authored by: mhorne >>      MFC after:      1 month >>      Differential Revision: https://reviews.freebsd.org/D30554 > > Thanks!  I actually had an earlier version of this but hadn't managed to > get it > tested on powerpc.  I had it as part of a branch to cleanup > bus_activate_resource > methods across various architectures whcih I will now rebase and try to > finish > up. > > If you are curious: > https://github.com/freebsd/freebsd-src/compare/main...bsdjhb:freebsd:bus_map_resource_more > Hey, very nice. I definitely saw a lot of cleanup potential and it seems like your branch does a lot in that respect. I have a couple of follow-ups in the area, so I will get those up into phab shortly. Mitchell