From owner-freebsd-hackers@FreeBSD.ORG Tue Nov 16 22:19:06 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 86942106566B; Tue, 16 Nov 2010 22:19:06 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 93E038FC1B; Tue, 16 Nov 2010 22:19:05 +0000 (UTC) Received: by wyb35 with SMTP id 35so404212wyb.13 for ; Tue, 16 Nov 2010 14:19:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=rOFBbTuxnWVzfOftmlbfnyGT7hp18rmVRlPxXG5z55k=; b=bevQ/h60xMvnyZanJjyklwScfmVOnBve2A1fFFoWWJJIq0DUmuC2aJCjMgPSEsMzZH UnMFbfKbujzp+BDpkRhTLAbVa8NQunzZJezx7WsOHYee3glCcPIhMNJBFgjRuUHiPGq5 Xj6oXMszxrbMa1Hi30ohDxiXih63p28c9X8Rw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=H2M4odKKt7rXZGV+6LPh2En8SsCMV5LB87XYhRRRWxWoXARfHFsC3W1HbTV+ZuYqGN u57PsyoHxVYlchEUpblpM6KH9sML3xzISjQWR5dlS2AfNJxCLHZpoiMNiSpsVxBRUw1Z jkQth5GPT2XLoA833na22BWqTQCgkWq6zhbfs= MIME-Version: 1.0 Received: by 10.216.46.19 with SMTP id q19mr650148web.0.1289945944342; Tue, 16 Nov 2010 14:19:04 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.216.65.210 with HTTP; Tue, 16 Nov 2010 14:19:04 -0800 (PST) In-Reply-To: References: <201011160829.13511.jhb@freebsd.org> <4CE28AE4.70101@yandex.ru> <201011160912.27693.jhb@freebsd.org> Date: Wed, 17 Nov 2010 06:19:04 +0800 X-Google-Sender-Auth: uiFfRJjXQAW4V5XYeqP1Z5v_KTc Message-ID: From: Adrian Chadd To: Garrett Cooper Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Bruce Cran , freebsd-hackers@freebsd.org, "Andrey V. Elsukov" , freebsd-current@freebsd.org Subject: Re: breaking the crunchgen logic into a share/mk file X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2010 22:19:06 -0000 Oops, I can't believe I committed the wrong version of this damned thing. I'll go and commit that particular un-braindamage. in a sec. Sorry everyone. Adrian On 17 November 2010 02:04, Garrett Cooper wrote: > On Tue, Nov 16, 2010 at 9:52 AM, Garrett Cooper wro= te: >> On Tue, Nov 16, 2010 at 6:12 AM, John Baldwin wrote: >>> On Tuesday, November 16, 2010 8:45:08 am Andrey V. Elsukov wrote: >>>> On 16.11.2010 16:29, John Baldwin wrote: >>>> > Err, are there no longer hard links to all of the frontends for a gi= ven >>>> > crunch? =A0If so, that is a problem as it will make rescue much hard= er to use. >>>> >>>> Yes, probably this patch is not needed and it should be fixed somewher= e in >>>> makefiles. But currently rescue does not have any hardlinks: >>>> http://pub.allbsd.org/FreeBSD-snapshots/i386-i386/9.0-HEAD-20101116-JP= SNAP/cdrom/livefs/rescue/ >>>> >>>> And what is was before: >>>> http://pub.allbsd.org/FreeBSD-snapshots/i386-i386/9.0-HEAD-20101112-JP= SNAP/cdrom/livefs/rescue/ >>> >>> That definitely needs to be fixed. >> >> =A0 =A0The .mk file wasn't being installed. Could someone please test >> this patch for validity and commit it? >> =A0 =A0More importantly, why didn't the above build process, or tinderbo= x >> fail properly with this change? > > Ouch. I can definitely still see the other problem: > > # make install > install -s -o root -g wheel -m 555 =A0 rescue /rescue > install -o root =A0-g wheel -m 555 =A0nextboot_FIXED =A0/rescue/nextboot > install -o root =A0-g wheel -m 555 =A0dhclient_FIXED =A0/rescue/dhclient-= script > > The second attached patch (not a superset of the first) what unbreaks it: > > # make -C rescue/rescue/ install > install -s -o root -g wheel -m 555 =A0 rescue /rescue > install -o root =A0-g wheel -m 555 =A0nextboot_FIXED =A0/rescue/nextboot > install -o root =A0-g wheel -m 555 =A0dhclient_FIXED =A0/rescue/dhclient-= script > /rescue/cat -> /rescue/rescue > /rescue/chflags -> /rescue/rescue > /rescue/chio -> /rescue/rescue > /rescue/chmod -> /rescue/rescue > /rescue/cp -> /rescue/rescue > /rescue/date -> /rescue/rescue > /rescue/dd -> /rescue/rescue > /rescue/df -> /rescue/rescue > /rescue/echo -> /rescue/rescue > /rescue/ed -> /rescue/rescue > /rescue/red -> /rescue/rescue > /rescue/expr -> /rescue/rescue > /rescue/getfacl -> /rescue/rescue > /rescue/hostname -> /rescue/rescue > /rescue/kenv -> /rescue/rescue > /rescue/kill -> /rescue/rescue > /rescue/ln -> /rescue/rescue > /rescue/link -> /rescue/rescue > /rescue/ls -> /rescue/rescue > /rescue/mkdir -> /rescue/rescue > /rescue/mv -> /rescue/rescue > /rescue/pkill -> /rescue/rescue > /rescue/pgrep -> /rescue/rescue > /rescue/ps -> /rescue/rescue > /rescue/pwd -> /rescue/rescue > /rescue/realpath -> /rescue/rescue > /rescue/rm -> /rescue/rescue > /rescue/unlink -> /rescue/rescue > /rescue/rmdir -> /rescue/rescue > /rescue/setfacl -> /rescue/rescue > /rescue/sh -> /rescue/rescue > /rescue/stty -> /rescue/rescue > /rescue/sync -> /rescue/rescue > /rescue/test -> /rescue/rescue > /rescue/[ -> /rescue/rescue > /rescue/csh -> /rescue/rescue > /rescue/tcsh -> /rescue/rescue > /rescue/atacontrol -> /rescue/rescue > /rescue/badsect -> /rescue/rescue > /rescue/camcontrol -> /rescue/rescue > /rescue/ccdconfig -> /rescue/rescue > /rescue/clri -> /rescue/rescue > /rescue/devfs -> /rescue/rescue > /rescue/dmesg -> /rescue/rescue > /rescue/dump -> /rescue/rescue > /rescue/rdump -> /rescue/rescue > /rescue/dumpfs -> /rescue/rescue > /rescue/dumpon -> /rescue/rescue > /rescue/fsck -> /rescue/rescue > /rescue/fsck_ffs -> /rescue/rescue > /rescue/fsck_4.2bsd -> /rescue/rescue > /rescue/fsck_ufs -> /rescue/rescue > /rescue/fsck_msdosfs -> /rescue/rescue > /rescue/fsdb -> /rescue/rescue > /rescue/fsirand -> /rescue/rescue > /rescue/gbde -> /rescue/rescue > /rescue/geom -> /rescue/rescue > /rescue/glabel -> /rescue/rescue > /rescue/gpart -> /rescue/rescue > /rescue/ifconfig -> /rescue/rescue > /rescue/init -> /rescue/rescue > /rescue/kldconfig -> /rescue/rescue > /rescue/kldload -> /rescue/rescue > /rescue/kldstat -> /rescue/rescue > /rescue/kldunload -> /rescue/rescue > /rescue/ldconfig -> /rescue/rescue > /rescue/md5 -> /rescue/rescue > /rescue/mdconfig -> /rescue/rescue > /rescue/mdmfs -> /rescue/rescue > /rescue/mknod -> /rescue/rescue > /rescue/mount -> /rescue/rescue > /rescue/mount_cd9660 -> /rescue/rescue > /rescue/mount_msdosfs -> /rescue/rescue > /rescue/mount_nfs -> /rescue/rescue > /rescue/mount_ntfs -> /rescue/rescue > /rescue/mount_nullfs -> /rescue/rescue > /rescue/mount_udf -> /rescue/rescue > /rescue/mount_unionfs -> /rescue/rescue > /rescue/newfs -> /rescue/rescue > /rescue/newfs_msdos -> /rescue/rescue > /rescue/nos-tun -> /rescue/rescue > /rescue/ping -> /rescue/rescue > /rescue/reboot -> /rescue/rescue > /rescue/fastboot -> /rescue/rescue > /rescue/halt -> /rescue/rescue > /rescue/fasthalt -> /rescue/rescue > /rescue/restore -> /rescue/rescue > /rescue/rrestore -> /rescue/rescue > /rescue/rcorder -> /rescue/rescue > /rescue/route -> /rescue/rescue > /rescue/routed -> /rescue/rescue > /rescue/rtquery -> /rescue/rescue > /rescue/rtsol -> /rescue/rescue > /rescue/savecore -> /rescue/rescue > /rescue/spppcontrol -> /rescue/rescue > /rescue/swapon -> /rescue/rescue > /rescue/sysctl -> /rescue/rescue > /rescue/tunefs -> /rescue/rescue > /rescue/umount -> /rescue/rescue > /rescue/bsdlabel -> /rescue/rescue > /rescue/disklabel -> /rescue/rescue > /rescue/fdisk -> /rescue/rescue > /rescue/dhclient -> /rescue/rescue > /rescue/head -> /rescue/rescue > /rescue/mt -> /rescue/rescue > /rescue/sed -> /rescue/rescue > /rescue/tail -> /rescue/rescue > /rescue/tee -> /rescue/rescue > /rescue/gzip -> /rescue/rescue > /rescue/gunzip -> /rescue/rescue > /rescue/gzcat -> /rescue/rescue > /rescue/zcat -> /rescue/rescue > /rescue/bzip2 -> /rescue/rescue > /rescue/bunzip2 -> /rescue/rescue > /rescue/bzcat -> /rescue/rescue > /rescue/xz -> /rescue/rescue > /rescue/unxz -> /rescue/rescue > /rescue/lzma -> /rescue/rescue > /rescue/unlzma -> /rescue/rescue > /rescue/xzcat -> /rescue/rescue > /rescue/lzcat -> /rescue/rescue > /rescue/tar -> /rescue/rescue > /rescue/vi -> /rescue/rescue > /rescue/ex -> /rescue/rescue > /rescue/id -> /rescue/rescue > /rescue/groups -> /rescue/rescue > /rescue/whoami -> /rescue/rescue > /rescue/chroot -> /rescue/rescue > /rescue/chown -> /rescue/rescue > /rescue/chgrp -> /rescue/rescue > > So it looks like something tunable needs to be added to the .mk file > to deal with hardlinks as this basically reenables functionality that > Adrian disabled. > > Thanks, > -Garrett >