From owner-dev-commits-src-all@freebsd.org Thu Feb 18 23:57:22 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1B22B52F2A3; Thu, 18 Feb 2021 23:57:22 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DhWpp02yvz4XMP; Thu, 18 Feb 2021 23:57:22 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com [66.111.4.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bdragon/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id E25B8A7E4; Thu, 18 Feb 2021 23:57:21 +0000 (UTC) (envelope-from bdragon@FreeBSD.org) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailauth.nyi.internal (Postfix) with ESMTP id 781FA27C0054; Thu, 18 Feb 2021 18:57:21 -0500 (EST) Received: from imap38 ([10.202.2.88]) by compute3.internal (MEProxy); Thu, 18 Feb 2021 18:57:21 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrjeehgdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecufghrlhcuvffnffculddutddmnecujfgurhepofgfgg fkjghffffhvffutgesthdtredtreerjeenucfhrhhomhepfdeurhgrnhguohhnuceuvghr ghhrvghnfdcuoegsughrrghgohhnsefhrhgvvgeuufffrdhorhhgqeenucggtffrrghtth gvrhhnpeejhfeftddutdelgeekgedtgeejkeffvdejtddthefggfevuefggfefledvgefh gfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegsug hrrghgohhnodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqddutdegvdefheek ieegqddukedutdekheduqdgsughrrghgohhnpeephfhrvggvuefuffdrohhrghesihhmrg hprdgttg X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id F2C93CA005D; Thu, 18 Feb 2021 18:57:20 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-141-gf094924a34-fm-20210210.001-gf094924a Mime-Version: 1.0 Message-Id: In-Reply-To: References: <202102180035.11I0ZnL3070354@gitrepo.freebsd.org> <9687575c-dd7c-1496-850b-2018f4bca3da@FreeBSD.org> Date: Thu, 18 Feb 2021 17:57:00 -0600 From: "Brandon Bergren" To: "Jessica Clarke" , "Konstantin Belousov" Cc: "John Baldwin" , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: =?UTF-8?Q?Re:_git:_24fd63e0970f_-_main_-_mips:_Don't_set_=5F=5FNO=5FTLS_?= =?UTF-8?Q?to_disable_some_uses_of_TLS.?= Content-Type: text/plain X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Feb 2021 23:57:22 -0000 On Thu, Feb 18, 2021, at 3:07 PM, Jessica Clarke wrote: > > But, I wonder, what does CALL_ELF mean? Is it for old 64bit PowerPC ABI, > > that was abandoned with the switch to ELFv2? > > Yes, _CALL_ELF == 2 for ELFv2. I highly doubt the defines were needed > for the ELFv1 ABI, but they're especially redundant now. Presumably > David's original fixed commit[1] added powerpc64 to that list because > TLS wasn't yet supported in LLVM; that happened later in 2012 and our > wiki changed it to being implemented in December 2012[2]. So I suspect > it should have been deleted 8 years ago. FreeBSD 13 will be the first ELFv2 release. FreeBSD 12 and below are ELFv1. The reason for the line was to avoid breaking things during the development period for ELFv2. Switching TLS on was one of the things I did at the same time as the official ELFv2 transition. See 2db975b0eb0f3378a39d63eeabe4e3617f4557f0. This is NOT an 8 year old change, but I believe it can go away in HEAD as long as the change isn't MFC'd to 12 or earlier. -- Brandon Bergren bdragon@FreeBSD.org