From owner-dev-commits-src-main@freebsd.org Tue Apr 27 07:01:26 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E5918622854; Tue, 27 Apr 2021 07:01:26 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FTt3B5rHBz3LT6; Tue, 27 Apr 2021 07:01:26 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wr1-x435.google.com with SMTP id e5so29634095wrg.7; Tue, 27 Apr 2021 00:01:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=eeRnfj8I905ca9dTAOMnUd2ZobeiTU7bX/Ik8CCNPI8=; b=isn5vEt9Ae4+UzO0Lc1bEPwqZ74LWealXRGc8e5mwMRRbjUAjVgnhtofV6eA9oun7l nUIIPR1QljE9dD1x+6f/bCWrxxowLGe/Z/wfFQf0kt8QGB2fw1Vm+hf4sBMcN/8CM8ya DAo/u7s9ePMSoEuuMXLaULnVLlnXu1OQMdtG27EhTRr0nxVcdYUGSMEltLREi76b0e3f oM1+kYhTkwYeqXbWKOrbiDUKJA+o7VWf/r1b8O01GGCqCAVRI/JUCE6pSj3X3Ra6JPL5 NggC8rEpKiDvfyDU0OwheK15wiMmpoLT4BNCLpDblK3/FMYEjatkZFhxYIpYJjhb4oJ9 um4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=eeRnfj8I905ca9dTAOMnUd2ZobeiTU7bX/Ik8CCNPI8=; b=CGZbeoNeqKFzGgs9fnazeKQqPkU9ZtQKP4RBPkBCxc++EA+4BbgjhuL2w0ISCD6wKI E6kjO2HColQ83nDNTrLosoSwiOfcUriaNQsbJWFi8fd0DuMIEaVKXsdaLNA2yiAe3GQF 4+VXw9CzjcjSYy0tRHYrFmfUv31aHOvB+l2N7igZA3SaTWsFXdJVoZP5iAjelKume/7x eS21MR3vcJDuQeVbGgsYKevv6gqg0ydGjj7lbLRxBlJfJfnv6eyxuf9AiTQx2GdQ4dbE ypsB7gl2564P598W5WswWqbfLjVQTikiZCNt0rKixSPVBaKm9PxdcC/+a6knk9iScF+M RmBw== X-Gm-Message-State: AOAM533yM4l7f8ZA2dlAjt3mQ9X3dZQxnW0ija7VkV4lJEwqgaWUNCfL 4X8Fm2JCbi5i2su/dEpEJLjFLTLPP+M= X-Google-Smtp-Source: ABdhPJwgjD4AnnLWBTnaH7pCKOSfeb004M5kiemwZ3OkjfEsoAyLvy2NyNSsWkuE0vWN8Hav8Rd63A== X-Received: by 2002:a05:6000:1785:: with SMTP id e5mr27560248wrg.143.1619506884672; Tue, 27 Apr 2021 00:01:24 -0700 (PDT) Received: from ernst.home (pd9e23d76.dip0.t-ipconnect.de. [217.226.61.118]) by smtp.gmail.com with ESMTPSA id a15sm3318323wrx.9.2021.04.27.00.01.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 00:01:24 -0700 (PDT) Date: Tue, 27 Apr 2021 09:01:22 +0200 From: Gary Jennejohn To: Kevin Bowling Cc: Rick Macklem , Neel Chauhan , src-committers , "dev-commits-src-all@FreeBSD.org" , "dev-commits-src-main@FreeBSD.org" Subject: Re: git: e657f3de6dc2 - main - linuxkpi: Remove unneeded {} in atomic_dec_and_lock_irqsave() Message-ID: <20210427070122.302abed2@ernst.home> In-Reply-To: References: <202104261525.13QFPrbg086311@gitrepo.freebsd.org> <9b006e97a64d01d128d81bc09f0891ea@freebsd.org> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4FTt3B5rHBz3LT6 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Apr 2021 07:01:27 -0000 On Mon, 26 Apr 2021 17:16:01 -0700 Kevin Bowling wrote: > Yup, I don't want to fatigue Neel or the tree with unnecessary churn, > he had the parens, someone said something about brackets {} and he > removed the parens. Since the function needs a rework per mjg's > review, it could be done when that occurs. > I'd say that the misunderstanding was caused by the use of the word brackets in the comment. Looking up bracket on wiktionary gives this definitiotn: 5. Any of the characters "(", ")", "[", "]", "{", "}", "<" and ">", used in pairs to enclose parenthetic remarks, sections of mathematical expressions, etc. (Britain) "(" and ")" specifically, the other forms above requiring adjectives for disambiguation. (US) "[" and "]" specifically - as opposed to the other forms, which have their own technical names. So, if Neel is used to BE he would remove the parens, which he did. I, as an American, would have been looking for [] and been confused by not finding any. So, in future it might be best to explicitly use e.g. {}, [], () in such comments. > On Mon, Apr 26, 2021 at 3:29 PM Rick Macklem wrote: > > > > Neel wrote: > > >On 2021-04-26 09:47, Kevin Bowling wrote: > > >> I'm not sure all the context or conversation here but the convention > > >> is to not use bare return values, i.e in style(9) "Values in return > > >> statements should be enclosed in parentheses." and that's what was > > >> asked to be changed on this mailing list. > > Just fyi to everyone, there is this in style(9): > > In general code can be considered ___new code___ when it makes up about 50% > > or more of the file(s) involved. This is enough to break precedents in > > the existing code and use the current style guidelines. > > > > As such, if the "return 0;" predates this patch series, Neel is correct > > to use "return 1;", since that precedent has already been established. > > I'll admit I see the above ignored a lot and personally don't care if > > the above generality is followed, but it is in style(9) and I do > > think a consistent style is preferred over a jumble within a source file. > > > > rick > > > > The review: https://reviews.freebsd.org/D29988 > > > > I believe I was asked to do this in the review. > > > > -Neel > > > > > > Can you use and link to Phabricator for your src commits? As much as > > > possible it is preferable to get it right in one go, for MFCs, > > > bisection, etc and this kind of churn should be preventable with quick > > > reviews. Feel free to tag me as a reviewer. > > > > Sure, will do next time. > > > > > > > Regards, > > > Kevin > > > > -Neel > > > _______________________________________________ > dev-commits-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all > To unsubscribe, send any mail to "dev-commits-src-all-unsubscribe@freebsd.org" -- Gary Jennejohn