From owner-freebsd-current@FreeBSD.ORG Tue Dec 22 14:19:44 2009 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 920E5106568B for ; Tue, 22 Dec 2009 14:19:44 +0000 (UTC) (envelope-from mexas@bristol.ac.uk) Received: from dirj.bris.ac.uk (dirj.bris.ac.uk [137.222.10.78]) by mx1.freebsd.org (Postfix) with ESMTP id 504EF8FC12 for ; Tue, 22 Dec 2009 14:19:44 +0000 (UTC) Received: from seis.bris.ac.uk ([137.222.10.93]) by dirj.bris.ac.uk with esmtp (Exim 4.69) (envelope-from ) id 1NN5aO-00057k-CT; Tue, 22 Dec 2009 14:19:43 +0000 Received: from mech-cluster241.men.bris.ac.uk ([137.222.187.241]) by seis.bris.ac.uk with esmtp (Exim 4.67) (envelope-from ) id 1NN5aN-0000H5-Gk; Tue, 22 Dec 2009 14:19:40 +0000 Received: from mech-cluster241.men.bris.ac.uk (localhost [127.0.0.1]) by mech-cluster241.men.bris.ac.uk (8.14.3/8.14.3) with ESMTP id nBMEJdvD060904; Tue, 22 Dec 2009 14:19:39 GMT (envelope-from mexas@bristol.ac.uk) Received: (from mexas@localhost) by mech-cluster241.men.bris.ac.uk (8.14.3/8.14.3/Submit) id nBMEJdRN060903; Tue, 22 Dec 2009 14:19:39 GMT (envelope-from mexas@bristol.ac.uk) X-Authentication-Warning: mech-cluster241.men.bris.ac.uk: mexas set sender to mexas@bristol.ac.uk using -f Date: Tue, 22 Dec 2009 14:19:39 +0000 From: Anton Shterenlikht To: "b. f." Message-ID: <20091222141939.GA60890@mech-cluster241.men.bris.ac.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) X-Spam-Score: -1.5 X-Spam-Level: - Cc: freebsd-current@FreeBSD.org, Anton Shterenlikht Subject: Re: still trouble with pci.c on i386 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Dec 2009 14:19:44 -0000 On Sun, Dec 20, 2009 at 08:22:42PM -0500, b. f. wrote: > Try reverting all of the changes in: > > http://svn.freebsd.org/changeset/base/200341 > > In particular, those to sys/dev/pci/pci_pci.c, which you don't seem to > have reverted. It is a bit easier to do this (with svn merge -c ... > or the like) if you keep your sources in a local subversion > repository, and since most of the base system developers are now using > that VCS, it is easier to get help by referring to the subversion > version numbers rather than the corresponding CVS version numbers. > jkim@, jhb@, and imp@ should be able to tell you more about this > problem. thanks for svn, seems a good idea. However, I'm not sure what the strategy is for reverting to previous revisions. For example if I know (from previous posts) that r 200341 breaks src/sys/dev/pci/pci.c and pci_pci.c, then which revision should I sync with? Just to illustrate: First I updated all src: svn update svn://svn.freebsd.org/base/head /usr/src then I reverted to r 200315, but only for pci src: svn update -r 200315 svn://svn.freebsd.org/base/head/sys/dev/pci /usr/src/sys/dev/pci Is this what I should've done? I still get panic with this revision. What am doing wrong? many thanks anton -- Anton Shterenlikht Room 2.6, Queen's Building Mech Eng Dept Bristol University University Walk, Bristol BS8 1TR, UK Tel: +44 (0)117 331 5944 Fax: +44 (0)117 929 4423