From owner-freebsd-usb@freebsd.org Sun Mar 8 13:15:22 2020 Return-Path: Delivered-To: freebsd-usb@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 724D72693C5 for ; Sun, 8 Mar 2020 13:15:22 +0000 (UTC) (envelope-from Shichun.Ma@dell.com) Received: from mx0b-00154904.pphosted.com (mx0b-00154904.pphosted.com [148.163.137.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 48b2065nBzz3Dxg for ; Sun, 8 Mar 2020 13:15:18 +0000 (UTC) (envelope-from Shichun.Ma@dell.com) Received: from pps.filterd (m0170394.ppops.net [127.0.0.1]) by mx0b-00154904.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 028D6DBx003840 for ; Sun, 8 Mar 2020 09:15:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=smtpout1; bh=cbId43re2vsSf1XX1/bPN31YKkcgVOouw2voLNlES8E=; b=m9JKvnOKrxtYTPePF4Qsdg6G8Q1IhVnJbI42UgpJs8/ZH7hfVuBSwmcGZrlo290DP6YG ltptiRR6OpVzejY/J3mn+5T7dCowOoXZbZpOgNKL2h9ZVfRxRozCwuE7u/fZcRG2xE5k cEf7H4VGAv0+WJK8mx6qvU2HMoaZV03Yn3zu0wXLm33vBh4Jcvn+QMgI3SVDFdSR/DSa q0MUWSLFsaoOhDtbVWjzAq2lsPQ4zRdkPRqdi4HENMiBjN93GUxsQPFqFCAzpSEmid/l 0qXd48xjfjZa1x0W0ThRIm6PXRMXMVEujCdYzYBeOFIm7p5SFBr4q6GYUBEWkBI+Ox2P QQ== Received: from mx0b-00154901.pphosted.com (mx0b-00154901.pphosted.com [67.231.157.37]) by mx0b-00154904.pphosted.com with ESMTP id 2ym72d2mxh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 08 Mar 2020 09:15:17 -0400 Received: from pps.filterd (m0144104.ppops.net [127.0.0.1]) by mx0b-00154901.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 028DEKto142510 for ; Sun, 8 Mar 2020 09:15:16 -0400 Received: from ausc60ps301.us.dell.com (ausc60ps301.us.dell.com [143.166.148.206]) by mx0b-00154901.pphosted.com with ESMTP id 2ym5rrdcb6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 08 Mar 2020 09:15:16 -0400 X-LoopCount0: from 10.166.135.101 X-PREM-Routing: D-Outbound X-IronPort-AV: E=Sophos;i="5.60,349,1549951200"; d="scan'208";a="1416865585" From: To: , CC: Subject: RE: Error bit using of wPortStatus when need usbd_req_warm_reset_port Thread-Topic: Error bit using of wPortStatus when need usbd_req_warm_reset_port Thread-Index: AdX1OsB0WutiOWAtTBOATA/PSV/V7f//kaSA//9wUQA= Date: Sun, 8 Mar 2020 13:15:12 +0000 Message-ID: <985d07eb112c4497a7dd95f72e3d8134@KULX13MDC130.APAC.DELL.COM> References: <13174e356c0640ab84fd697a1ae28e55@KULX13MDC130.APAC.DELL.COM> <8b8ae413-29d2-1b0b-1037-cf3b49c1baf7@selasky.org> In-Reply-To: <8b8ae413-29d2-1b0b-1037-cf3b49c1baf7@selasky.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_a17f17c0-b23c-493d-99ab-b037779ecd33_Enabled=True; MSIP_Label_a17f17c0-b23c-493d-99ab-b037779ecd33_SiteId=945c199a-83a2-4e80-9f8c-5a91be5752dd; MSIP_Label_a17f17c0-b23c-493d-99ab-b037779ecd33_Owner=Shichun_Ma@Dell.com; MSIP_Label_a17f17c0-b23c-493d-99ab-b037779ecd33_SetDate=2020-03-08T13:15:07.9177882Z; MSIP_Label_a17f17c0-b23c-493d-99ab-b037779ecd33_Name=Customer Communication; MSIP_Label_a17f17c0-b23c-493d-99ab-b037779ecd33_Application=Microsoft Azure Information Protection; MSIP_Label_a17f17c0-b23c-493d-99ab-b037779ecd33_Extended_MSFT_Method=Manual; aiplabel=Customer Communication x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [125.252.73.115] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-03-08_04:2020-03-06, 2020-03-08 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 clxscore=1015 mlxscore=0 bulkscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 mlxlogscore=725 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003080100 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 spamscore=0 mlxlogscore=863 malwarescore=0 lowpriorityscore=0 suspectscore=0 mlxscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003080099 X-Rspamd-Queue-Id: 48b2065nBzz3Dxg X-Spamd-Bar: ------- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=dell.com header.s=smtpout1 header.b=m9JKvnOK; dmarc=pass (policy=none) header.from=dell.com; spf=pass (mx1.freebsd.org: domain of Shichun.Ma@dell.com designates 148.163.137.20 as permitted sender) smtp.mailfrom=Shichun.Ma@dell.com X-Spamd-Result: default: False [-7.61 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.96)[-0.963,0]; R_DKIM_ALLOW(-0.20)[dell.com:s=smtpout1]; HAS_XOIP(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; RCVD_COUNT_FIVE(0.00)[5]; R_SPF_ALLOW(-0.20)[+ip4:148.163.137.20]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-usb@freebsd.org]; TO_DN_NONE(0.00)[]; DWL_DNSWL_LOW(-1.00)[dell.com.dwl.dnswl.org : 127.0.9.1]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[dell.com:+]; DMARC_POLICY_ALLOW(-0.50)[dell.com,none]; FROM_NO_DN(0.00)[]; IP_SCORE(-0.55)[ip: (-0.24), ipnet: 148.163.137.0/24(-0.10), asn: 22843(-2.34), country: US(-0.05)]; RCVD_IN_DNSWL_LOW(-0.10)[20.137.163.148.list.dnswl.org : 127.0.3.1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:22843, ipnet:148.163.137.0/24, country:US]; RCVD_TLS_LAST(0.00)[]; WHITELIST_SPF_DKIM(-3.00)[dell.com:d:+,dell.com:s:+] X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Mar 2020 13:15:22 -0000 Dell Customer Communication - Confidential Hi HPS, Thanks your kindly explanation. The patch works with my device, please commit to main stream. Regards, Horse Ma (Shichun Ma) Software Engineer Dell | Cloud client-computing - Wyse office +86 10 82862579,=A0 Mobile +86 13241851528 See our products at www.dell.com/wyse -----Original Message----- From: Hans Petter Selasky =20 Sent: Sunday, March 8, 2020 8:40 PM To: Ma, Horse; freebsd-usb@freebsd.org Cc: Hu, Shunchao Subject: Re: Error bit using of wPortStatus when need usbd_req_warm_reset_p= ort [EXTERNAL EMAIL]=20 On 2020-03-08 12:15, Shichun.Ma@dell.com wrote: > Link info need 4 bits and they take bit 5 to bit 9, while UPS_PORT_POWER= takes bit 9. > So this will give wrong link state info in function uhub_suspend_resume_p= ort when it check if need usbd_req_warm_reset_port. > Please review and kindly suggest how to fix this issue. Hi, You are absolutely right. Good catch. I think we will just remove the POWER bit from the super speed RH. It is cu= rrently not needed for anything. Then the LINK state values won't be clobbe= red like you found. Does the attached patch work for you? --HPS