From owner-freebsd-alpha@FreeBSD.ORG Wed May 13 23:59:24 2009 Return-Path: Delivered-To: alpha@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8319A106564A; Wed, 13 May 2009 23:59:24 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.freebsd.org (Postfix) with ESMTP id 4B27A8FC12; Wed, 13 May 2009 23:59:24 +0000 (UTC) (envelope-from des@des.no) Received: from ds4.des.no (des.no [84.49.246.2]) by smtp.des.no (Postfix) with ESMTP id CB6726D449; Thu, 14 May 2009 01:47:38 +0200 (CEST) Received: by ds4.des.no (Postfix, from userid 1001) id AAEF184497; Thu, 14 May 2009 01:47:38 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: alpha@freebsd.org, hackers@freebsd.org Date: Thu, 14 May 2009 01:47:38 +0200 Message-ID: <86tz3o4lb9.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Subject: PTE modified bit emulation trap X-BeenThere: freebsd-alpha@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the Alpha List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 May 2009 23:59:24 -0000 Coverity complains about the lack of error checking in the following code in sys/kern/kern_sysctl.c, around line 1390: /* * Touch all the wired pages to avoid PTE modified * bit emulation traps on Alpha while holding locks * in the sysctl handler. */ for (i =3D (wiredlen + PAGE_SIZE - 1) / PAGE_SIZE, cp =3D req->oldptr; i > 0; i--, cp +=3D PAGE_SIZE) { copyin(cp, &dummy, 1); copyout(&dummy, cp, 1); } Since Alpha is dead, can we remove this, or is it still needed for other platforms? DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no