From owner-freebsd-java@FreeBSD.ORG Mon Aug 25 21:08:38 2003 Return-Path: Delivered-To: freebsd-java@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4772416A4BF; Mon, 25 Aug 2003 21:08:38 -0700 (PDT) Received: from mail.chesapeake.net (chesapeake.net [208.142.252.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3485543FBF; Mon, 25 Aug 2003 21:08:37 -0700 (PDT) (envelope-from jroberson@chesapeake.net) Received: from localhost (jroberson@localhost) by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id h7Q48VR79478; Tue, 26 Aug 2003 00:08:31 -0400 (EDT) (envelope-from jroberson@chesapeake.net) Date: Tue, 26 Aug 2003 00:08:31 -0400 (EDT) From: Jeff Roberson To: David Xu In-Reply-To: <3F4ADC3D.1080908@viatech.com.cn> Message-ID: <20030826000750.N12093-100000@mail.chesapeake.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: "deischen@freebsd.org" cc: "threads@freebsd.org" cc: "freebsd-java@freebsd.org" Subject: Re: vmark hangs with libthr and libkse X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Aug 2003 04:08:38 -0000 On Tue, 26 Aug 2003, David Xu wrote: > Jeff Roberson wrote: > > >On Mon, 25 Aug 2003, David Xu wrote: > > > > > > > >>Sheldon Hearn wrote: > >> > >> > >> > >>>On (2003/08/25 15:47), David Xu wrote: > >>> > >>> > >>> > >>> > >>> > >>>>>I heartily endorse your patch. :-) > >>>>> > >>>>> > >>>>> > >>>>> > >>>>> > >>>>Thanks, I am pleased to see libkse works. :-) > >>>>However don't expect I will commit it, kernel scheduler interface is a > >>>>bit weird, so > >>>>I won't try to add another weird code. > >>>> > >>>> > >>>> > >>>> > >>>Does Jeff know about your patch? Perhaps he'd be willing to review and > >>>commit, since he's the original author of SCHED_ULE. > >>> > >>> > >>> > >>> > >>No, I think he does not know the patch. > >>Please don't commit it, there is a performance problem, after each time > >>a thread is exited, > >>I must exit a kse and then let scheduler reinitialized it. In general, I > >>needn't manage a struct kse, > >>it should be a scheduler internal data. > >> > >> > >> > > > >Why do you need to do adjustrunqueue() in sched_prio? I also don't > >understand the case in sched_switchout(). Can you please explain that? > > > > > adjustrunqueue maintains kg_last_assigned and related things, when a > thread's priority is changed, > the thread might no longer can be in scheduler's run queue, instead it > will be in ksegrp's runqueue, > because there is higher priority thread, and a KSE it attached should be > detached now, and the KSE > will attach to another higher priority thread, ULE ignores this > requirement, as I can understand, > ULE is only aware of 1:1 between KSE and thread. > It would be nice if scheduler interface is thread aware but not kse aware. Yes, wouldn't it be nice.. I don't think it should be ksegrp aware either. oh well, it wasn't my design. Will you commit this patch? > > >Other than that this patch seems fine. KSE is technically missing the > >proper sched api calls which is why ULE doesn't work with it. > > > >Cheers, > >Jeff > > > >_______________________________________________ > >freebsd-threads@freebsd.org mailing list > >http://lists.freebsd.org/mailman/listinfo/freebsd-threads > >To unsubscribe, send any mail to "freebsd-threads-unsubscribe@freebsd.org" > > > > > > > > >