From nobody Sat Mar 19 21:24:02 2022 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5C0C81A195AE for ; Sat, 19 Mar 2022 21:24:17 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic312-24.consmr.mail.gq1.yahoo.com (sonic312-24.consmr.mail.gq1.yahoo.com [98.137.69.205]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4KLYmH6ZcXz3nvC for ; Sat, 19 Mar 2022 21:24:15 +0000 (UTC) (envelope-from marklmi@yahoo.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647725049; bh=lgrrCQyeKXAI4B4EqDJNybh63XpCkTHmu2j9AZgJBtM=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=QwLnxS+d62eAhB1RrTWfXTCZKhCX9Lfl5fY36m4rhf5eQUguD5E0TDkMCPs69TKPBpix1yu0Vy05Jg9zgU0zEVVOQTjnbmtPDrZqlioF4DWHTUQJP/xMq0WoUn6wELi0rhBqugSU4Kg/F6yrvkTsQGTyy2mv/hXVmZ0bF9r2qY6L/szn3OEbnktjycJGDrw5w++bbtpAhsc8iZKWpRAHpRjpBDB2PnJYaGqVVh5KSinFp+Sr6DTDmbIy0Gr4jrlUiSG6zugSoawWJSDa/4+RMIx7nuQiJLvRarBzwctlzbV1xA1CtyenJFXh4XOIRMYEjbi00CkZpYRoZVU+7ax86g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1647725049; bh=3DalWlvpf/jcPmGrkn29kJS1CZsfZzTKV/9USU/QC7C=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=H+PkAIe/KOfRwOUa4eQlKRZqjnMLHOc1VABFtRvSsPQ89G3cFQ9js8PfUJdNj/KphOJL1DP0rGzlhYS2ybVoAYT9/FUFXt7AEeKsCk+EgHdQ2zMtwUnbZDQfZa4QN2Pwf8+tfiCQ3Pvmasdz/usMzY1Dw+mHb3nb+9WYze/ivNhib5FgSJIDoWuBqeoVv3epEdMW4B3sA864ILpLqeft+q6udmvQMBWTbizKo3VVa9a2CA0wi2WC51jmxdvRrZgSe0CPuBFMxkVPkPvjIhs+FQB9ZZGVGFME7oN3tNyHteZAHVMoKdqaWMazHke5rKD7oLrJSCd1UR0cxH1buTrMbQ== X-YMail-OSG: fwHACT4VM1lH08IAMb3Dxd_tQKgaRry864ZEqcRIITFBFaIcncHlrD0P2utaixC Bh.ttBCXyVNrowOlGB6VidxzM0cvokWLk1bMUdNQxdaWmprRIEn_d4vqG33MNTq.rDoagfuEcFzx ojuKmCj6ScPAPBuTijTfgQJkCf3zMRNJTRvY45xK_V2FuIBiheY6auFOZS77qtIzybzlsvOFVEy9 lmu9Xfl7X6mZOEiyiq9VbrCvzRvw3QoU4v1TmvMAwoZxb7.QZOEacNpNzTswLlcP6f1FYNAH.rB7 2V7QBIWrs_pdCp6w4Z7pSh7vd0hDijImtnfQZ0gjB4b2ZMv.MUTXsVEXOpQVwWYVFfvRGXqT.jsr DAhFPcL4fpXg4E15_APdr146qrmvwD4Xkb0rNoMICdSfVVTCz.ul7cJugf34kGMES0ZhuHT8hbrr bmreuMweGy.Lp3rjMZS.TDIcz.XvnCbT1Sz4yKwZ7MfN2nHQGpDd_QaDBGQd8KTYXH.onxd3Sxyp wsCpCgDNIclFY53u9vkpW_vq7F9_JA89X1dDIqsPwybEtmQk.Giij8ZXdRKOslLtDk7HvvvZnW7z CtlKWHjp5Zek17ke8TFFyIfrpOz4QJd1_8K8LNgMtVkqldFTCYpdHQ4Rxe5WboX4EtNjsF_9xLRG Up19ah4Kf9pGl_gFCPfBG675parayNh02V9XlyqpIaJuhbLbmb59BIDBhow.u3J.dHF0MW4eTC5M CsF4Q7Id2uigJ0RKQR8bIH55fVWKieZ9PkYyQOiboGnfmHcjyGOtnvwo3cgTw9uHkq4wV9gwnCO1 4h07k5DwUKnva1tGPczvFK0noK53qR1mvScS62sYbxr7uC4q_s86Iaoaj9uSHaNpE9ToZ4M2a1PH oP7nt6nOUgn6lbXgPcqHqsV9xy7CyxZxSt9EHDvRot2KTS2JrQa5y0N54GZOSqx4Q_bSz.aFeTBU bM8aR90haVwRc3Syzkj_T9beaEhEIgS4gfsLFHFVXZMO3f2DFQHZw8HMMZYREF265G0_fyu2ljuj NavcPJQbpg6jCrYrPI1MW_SV3CGJ8ihmTNKRHTXx0pktpTs7BQISK8s5I6QEsUzPFVbrytaXl5LL 5LyUc1RBZebaRYJvbSk4GIDBMUSdr4o0tvTxYc4_PMXZEB1hIg9SjQnAIj.OLPOjeslLTeYrkqCq OlSRy5VNpI3YYLToR9.ftS_uqEMf_2jssskER1c_.2yBYVC2B_.JoEwIbXWHGCQSqv_WcJfPQ69_ ehqjzN4MBY9oTI3g1fZwMF_S6uVhZgoO9oRwAJxU6FrSdiUoVUDEf63BG7fqisZjSRJVoRBBGkmy nAGLmlyRu8NdQ8W7V0.Ubg2TSX2smICjZM5faLBWkRE3K.zwiy5WfqBatma4cFllCtDxEyZzMg8m hgCKw09DeBV6g_d1pWW2Ld3aAOhO2q10cPUhdiVF0lBZVra2u4gouUlN1osrt2U6v6hq0O4osbNf xIIsvLgCSeh_4JJTHh1cO0uQnI4fUrYCbHaG3GrsmBJnJ2_DingxoWJzsgM2ChMQpZ4oEmZa6_pl RNTMuFFOB5mSuotuLGRjbvLIyOq1WJKzgQoc.0uS0rky_3XsbEYCPpbS2cSsGbpVIxtz5OKT3yxE mGpJz6CctQ9LmRkOvW2LFOV3uvSXqwUxHqhi_NxffGCQS9OxapeV8DCATLI.h3RsQf9gAMiv11kR xBJQwpVLkeU1G7hSc3hGTX9LMIT7rWDEdsLDUPGpNBbjJsfLh8ayizS.l5ItxVmqlLSeoS3o3vIF DHaXFvOFUr26c6HcxPkbAivrtggJKRJL6C6Uuf85467kZfpv5VlMj2t8eFDBQiuXJ8AOEkDTndrp W9AGUX1MOAooHdnd6SH47UKDRDXeZt3hVl700qLxum8dgsfQbbP1XA7EfV7wXKpC7MAXh_Lj1sCS uQLriKLw4YA1CGT6M3_Rhrlo.7OTmKkgT3Jec7.rVkYbYwP.SJ3ufk6KfXoiBf1109Ezg__7Y4et kHWvgnWMWKlqAVBV8zowgNbbOJfpgIhf8ogvaz1_2jct_DhTUXCiFxORlik_ygeg2nslzwQHKAWT sRzce8A1eJVgLWsgf9qVMeCa988JFHeuBotoY9FR1G1PFyu1o0aynpSSDjgzTt9jSD_5H15AjXBK 53aKPtLTlAwE4juiuMtYivy0RmF79Or0XCxZBUWrd2kyYN4j7A4zn2gr.E7uw8t8fEjcZ9GLgXEM gsg2p5ZksTioADHeq5hm2mBCydBCa.ZU9O_SbdG_LY3ksAwObKkh4fy6Nvq1R7Vtq6iiGtlinPbS VUGSv3rmkv_1COWtNFr0r8DU- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.gq1.yahoo.com with HTTP; Sat, 19 Mar 2022 21:24:09 +0000 Received: by hermes--canary-production-bf1-665cdb9985-zm65g (VZM Hermes SMTP Server) with ESMTPA ID ca6c3fd6d19784f7989498373827cfbd; Sat, 19 Mar 2022 21:24:04 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: git: 43741377b143 - main - security/openssl: Security update to 1.1.1n From: Mark Millard In-Reply-To: Date: Sat, 19 Mar 2022 14:24:02 -0700 Cc: Thomas Zander , freebsd-ports@freebsd.org, FreeBSD-STABLE Mailing List Content-Transfer-Encoding: quoted-printable Message-Id: <4370EEAF-A332-4DEB-8E21-B24689857463@yahoo.com> References: <2E632408-4D4E-426C-8DC7-A1024A1D328D.ref@yahoo.com> <2E632408-4D4E-426C-8DC7-A1024A1D328D@yahoo.com> To: Mark Johnston X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Rspamd-Queue-Id: 4KLYmH6ZcXz3nvC X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=QwLnxS+d; dmarc=pass (policy=reject) header.from=yahoo.com; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.69.205 as permitted sender) smtp.mailfrom=marklmi@yahoo.com X-Spamd-Result: default: False [-1.57 / 15.00]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[yahoo.com]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; DKIM_TRACE(0.00)[yahoo.com:+]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; NEURAL_HAM_SHORT(-0.99)[-0.994]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; NEURAL_SPAM_MEDIUM(0.92)[0.921]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.69.205:from]; MLMMJ_DEST(0.00)[freebsd-ports]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.69.205:from]; RCVD_COUNT_TWO(0.00)[2] X-ThisMailContainsUnwantedMimeParts: N On 2022-Mar-19, at 12:54, Mark Johnston wrote: > On Sat, Mar 19, 2022 at 12:00:20PM -0700, Mark Millard wrote: >> On 2022-Mar-19, at 11:07, Thomas Zander wrote: >>=20 >>> On Sat, 19 Mar 2022 at 18:32, Mark Millard = wrote: >>>> May be report to Mark J. how to run the same test builds >>>> that failed for -p8 but worked for -p7? >>>=20 >>> Sure, good point. >>> A build that reliably causes broken packages on p8 but not on p7 for >>> me is running: >>>=20 >>> poudriere testport -o multimedia/mplayer -j <13.0-amd64-jail here> >>>=20 >>> This caused the broken png and python packages when they were built = as >>> dependencies. >>> In poudriere.conf I set this: >>> DISTFILES_CACHE=3D/vcache/distfiles >>> CCACHE_DIR=3D/vcache/ccache >>> ALLOW_MAKE_JOBS=3Dyes >>>=20 >>> The ALLOW_MAKE_JOBS should increase the number of parallel IO >>> operations in-flight on the pool, maybe this increases the = likelihood >>> of triggering the issue? >>> The DISTFILES_CACHE and CCACHE_DIR are in the same zfs pool as >>> /poudriere, not sure if this is relevant. >>> The zfs pool is a single disk, no raid, mirror or anything fancy. >>=20 >> On a ThreadRipper 1950X, PCIe Optane storage, 128 GiBytes of >> RAM, I've used bectl to boot the 13.0_RELEASE-p8 environment >> and have started: >>=20 >> poudriere testport -o multimedia/mplayer -j13_0R-amd64-bulk_a >>=20 >> where the jail had nothing built in it at the start. So: >>=20 >> [00:00:08] Building 271 packages using up to 32 builders >>=20 >> The primary difference is that I've never used ccache and >> did not try to do so here. The "zfs pool is a single disk, >> no raid, mirror or anything fancy" is accurate, as is the >> use of ALLOW_MAKE_JOBS=3D . >>=20 >> That did not take long . . . >>=20 >> It proves that ccache is not required. Also some files >> seem to get only small blocks of zero-bytes, others >> large ones. But I've not checked for the null characters >> being at the end instead of earlier in the file. >=20 > I still am not able to reproduce it. I think it's indeed a = concurrency > problem, and I found a possible culprit. Mark or Thomas, if you're = able > to build a new kernel from the releng/13.0 branch and test it, could = you > please try this patch? >=20 Sure. (I build ports in a way that allows large load averages relative to the hardware-thread count. I also have a lot of swap configured. I avoid significant use of tmpfs.) > diff --git a/sys/contrib/openzfs/module/zfs/dnode.c = b/sys/contrib/openzfs/module/zfs/dnode.c > index 8592c5f8c3a9..b69ba68ec780 100644 > --- a/sys/contrib/openzfs/module/zfs/dnode.c > +++ b/sys/contrib/openzfs/module/zfs/dnode.c > @@ -1661,7 +1661,7 @@ dnode_is_dirty(dnode_t *dn) > mutex_enter(&dn->dn_mtx); >=20 > for (int i =3D 0; i < TXG_SIZE; i++) { > - if (list_head(&dn->dn_dirty_records[i]) !=3D NULL) { > + if (multilist_link_active(&dn->dn_dirty_link[i])) { > mutex_exit(&dn->dn_mtx); > return (B_TRUE); > } >=20 Change made. Rebuilt. Reinstalled. Rebooted into the 13_0R-amd64 be area. Bulk build started. Bulk build completed. (Took longer because I let it run to completion.) No explicit reports of null characters. The same 2 ports that failed before, not reporting zero-byte issues, failed again. Likely independent issues: [00:28:28] Failed ports: security/libgcrypt:build = print/freetype2:package Overall it skipped something like 54 ports. libgcrypt-1.9.4.log . . . --- basic.o --- basic.c:315:16: error: inline assembly requires more registers than = available asm volatile("movdqu %[data0], %%xmm0\n" ^ basic.c:315:16: error: inline assembly requires more registers than = available basic.c:315:16: error: inline assembly requires more registers than = available basic.c:315:16: error: inline assembly requires more registers than = available basic.c:315:16: error: inline assembly requires more registers than = available basic.c:315:16: error: inline assembly requires more registers than = available basic.c:315:16: error: inline assembly requires more registers than = available basic.c:315:16: error: inline assembly requires more registers than = available basic.c:315:16: error: inline assembly requires more registers than = available basic.c:315:16: error: inline assembly requires more registers than = available basic.c:315:16: error: inline assembly requires more registers than = available basic.c:315:16: error: inline assembly requires more registers than = available --- mpitests --- . . . --- basic.o --- basic.c:315:16: error: inline assembly requires more registers than = available basic.c:315:16: error: inline assembly requires more registers than = available basic.c:315:16: error: inline assembly requires more registers than = available basic.c:315:16: error: inline assembly requires more registers than = available basic.c:315:16: error: inline assembly requires more registers than = available basic.c:315:16: error: inline assembly requires more registers than = available basic.c:315:16: error: inline assembly requires more registers than = available fatal error: too many errors emitted, stopping now [-ferror-limit=3D] freetype2-2.11.1.log . . . =3D=3D=3D> Building package for freetype2-2.11.1 pkg-static: Unable to access file = /wrkdirs/usr/ports/print/freetype2/work/stage/usr/local/lib/libfreetype.so= :No such file or directory pkg-static: Unable to access file = /wrkdirs/usr/ports/print/freetype2/work/stage/usr/local/lib/libfreetype.so= .6:No such file or directory pkg-static: Unable to access file = /wrkdirs/usr/ports/print/freetype2/work/stage/usr/local/lib/libfreetype.so= .6.18.1:No such file or directory *** Error code 1 I think this indicates that your fix works. For reference: # ~/fbsd-based-on-what-commit.sh -C /usr/ports/ branch: main merge-base: 0c4fe38bd1b9e3ede128751db17a8a2d1bdffe6f merge-base: CommitDate: 2022-03-15 16:15:33 +0000 0c4fe38bd1b9 (HEAD -> main, freebsd/main, freebsd/HEAD) misc/urh: Update = 2.9.2 -> 2.9.3 n577366 (--first-parent --count for merge-base) =3D=3D=3D Mark Millard marklmi at yahoo.com