From owner-freebsd-hackers@FreeBSD.ORG  Wed Jun 25 15:02:54 2003
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2B42137B401
	for <hackers@freebsd.org>; Wed, 25 Jun 2003 15:02:54 -0700 (PDT)
Received: from rwcrmhc11.attbi.com (rwcrmhc11.comcast.net [204.127.198.35])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 55A8844005
	for <hackers@freebsd.org>; Wed, 25 Jun 2003 15:02:53 -0700 (PDT)
	(envelope-from julian@elischer.org)
Received: from interjet.elischer.org ([12.233.125.100])
          by attbi.com (rwcrmhc11) with ESMTP
          id <2003062522025201300442g8e>; Wed, 25 Jun 2003 22:02:52 +0000
Received: from localhost (localhost.elischer.org [127.0.0.1])
	by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id PAA04567;
	Wed, 25 Jun 2003 15:02:52 -0700 (PDT)
Date: Wed, 25 Jun 2003 15:02:50 -0700 (PDT)
From: Julian Elischer <julian@elischer.org>
To: Dwayne MacKinnon <Dwayne.MacKinnon@xwave.com>
In-Reply-To: <3EF9A501.2090007@xwave.com>
Message-ID: <Pine.BSF.4.21.0306251435120.3793-100000@InterJet.elischer.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: hackers@freebsd.org
cc: Kris Kennaway <kris@obsecurity.org>
Subject: Re: pkg_create broken?
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Jun 2003 22:02:54 -0000



On Wed, 25 Jun 2003, Dwayne MacKinnon wrote:

> Hi all,
> 	Just wanted to chime in that I've encountered the exact same thing, 
> although it's a relatively recent thing... I think it happened when I 
> ported to 4.5 from 4.2.
> 
> 	The only solution I've found, pain in the neck that it is, is to create 
> the destination directories on the source box. That keeps pkg_create 
> happy, and the proper files are still picked up from the where they're 
> specified by SRCDIR.
> 
> 	I meant to raise this a long time ago, but I got busy, my package 
> creation box was set up so that pkg_create didn't complain, and out of 
> sight = out of mind... :-)

doing a ktrace on a dummy package shows the following information:

here's the test plist (in directory /tmp/x.x) being read in..

      "@cwd /tmp/cccc
        @srcdir /tmp/xx
        x.x
       "


this is the 'created' package description being written out..


       "@comment PKG_FORMAT_REVISION:1.1
        @name AAAA
        @cwd /tmp/cccc
        @srcdir /tmp/xx
        x.x
        @comment MD5:1d882c9823718b00feb42ba5707f9c71
        @cwd .
        @ignore
        +COMMENT
        @ignore
        +DESC
       "


And here's the command fed to tar..



       "+CONTENTS
        +COMMENT
        +DESC
        -C
        /tmp/cccc
        -C
        /tmp/xx
        x.x
        -C
        .
       "

The "-C /tmp/cccc" shouldn't be there. Somehow we need to delay the
emmitting of that set of options until it's known that there is no
srcdir following it. Alternatively, the man page hints that
a 'srcdir' would stop a following 'cwd' from having effect in the create
phase.
Unfortunatly changing the order of the entries or adding an arg for
srcdir doesn't remove the extra -C command.