From owner-freebsd-net@FreeBSD.ORG Mon Sep 26 08:14:17 2005 Return-Path: X-Original-To: net@freebsd.org Delivered-To: freebsd-net@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 651C916A41F; Mon, 26 Sep 2005 08:14:17 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id B560E43D4C; Mon, 26 Sep 2005 08:14:16 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received: from localhost (localhost [127.0.0.1]) by mp2.macomnet.net (8.13.3/8.13.3) with ESMTP id j8Q8EEZu051176; Mon, 26 Sep 2005 12:14:14 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Mon, 26 Sep 2005 12:14:14 +0400 (MSD) From: Maxim Konovalov To: "Crist J. Clark" In-Reply-To: <20050923175125.GA69254@goku.cjclark.org> Message-ID: <20050926121137.X7055@mp2.macomnet.net> References: <20050923175125.GA69254@goku.cjclark.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: net@freebsd.org Subject: Re: Fixed Dest Port for traceroute(8) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2005 08:14:17 -0000 [...] > Index: traceroute.c > =================================================================== > RCS file: /ncvs/freebsd/src/contrib/traceroute/traceroute.c,v > retrieving revision 1.27 > diff -u -r1.27 traceroute.c > --- traceroute.c 26 Aug 2005 18:08:24 -0000 1.27 > +++ traceroute.c 23 Sep 2005 17:47:45 -0000 [...] > @@ -521,13 +522,17 @@ > prog = argv[0]; > > opterr = 0; > - while ((op = getopt(argc, argv, "dFInrSvxf:g:i:M:m:P:p:q:s:t:w:z:")) != EOF) > + while ((op = getopt(argc, argv, "edFInrSvxf:g:i:M:m:P:p:q:s:t:w:z:")) != EOF) Better to keep the keys sorted alphabetically. I.e. "deFI..". Need to update usage() as well. -- Maxim Konovalov