From owner-freebsd-current@freebsd.org Mon Oct 12 20:20:08 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6C16CA1168E for ; Mon, 12 Oct 2015 20:20:08 +0000 (UTC) (envelope-from jason.unovitch@gmail.com) Received: from mail-ig0-x22b.google.com (mail-ig0-x22b.google.com [IPv6:2607:f8b0:4001:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3469017E6; Mon, 12 Oct 2015 20:20:08 +0000 (UTC) (envelope-from jason.unovitch@gmail.com) Received: by ignr19 with SMTP id r19so23156954ign.1; Mon, 12 Oct 2015 13:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=KMefe92AbOIg4sGO8HYu8dL5keWCOwcwdwdA8x+TcNQ=; b=qxjKdgbTNLQg6zCQnwtJxMd/gIQ+nMTOLZ5UV2536R52RxZQBFcd6xoWPtjhApf1Sp U/zxgJWOjiRJpjkwc/cjl9ERk43kdproWIm08+7GkcfQKfatJ26IuVWAykGZXVLQvu1y CpJA5eSO5Sql9tKZPHtEvUjYaKsCjFbltTLxiyh6mn+YwqgMu+op1tJaaBZzWkqG2f6B A2ie3wf3PynfJyhY/xywX0ZWuxwNeLxWn2BzLHo1QEX1A0MwNBkMqLQqCagLZQpzNaFd VsrhumMjucMHO4JJSVBqlMyfcoiHbU2qJSON5jHPoN08wIk90qBk+4+gwurZFYdGrF4j doqA== MIME-Version: 1.0 X-Received: by 10.50.43.234 with SMTP id z10mr15733961igl.53.1444681207657; Mon, 12 Oct 2015 13:20:07 -0700 (PDT) Received: by 10.36.0.134 with HTTP; Mon, 12 Oct 2015 13:20:07 -0700 (PDT) In-Reply-To: <561C1523.7080200@FreeBSD.org> References: <561C1523.7080200@FreeBSD.org> Date: Mon, 12 Oct 2015 16:20:07 -0400 Message-ID: Subject: Re: r288669 breaks ports building with USE_GCC=yes From: Jason Unovitch To: Pedro Giffuni Cc: Justin Hibbits , FreeBSD Current Content-Type: text/plain; charset=UTF-8 X-Mailman-Approved-At: Mon, 12 Oct 2015 20:37:22 +0000 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2015 20:20:08 -0000 On Mon, Oct 12, 2015 at 4:16 PM, Pedro Giffuni wrote: > Hello; > > On 12/10/2015 02:56 p.m., Justin Hibbits wrote: >> >> The default ports gcc for USE_GCC is still 4.8, which does not support >> -fstack-protector-strong. This breaks several ports including (from >> my poudriere run): libfpx and qt4-sqlite3-plugin. >> >> - Justin > > > r288669 only applies to base. It was tested with an exp-run and there were > no > failures so this is something wrong in your setup. > > This said, --stack-protector-strong was being considered for ports, so > portmgr > should consider changing USE_GCC to 4.9 before that. > > regards, > > Pedro. > > _______________________________________________ I've been toying with a patch to use -fstack-protector-strong when available with the base compilers as well as detecting the ports GCC version and either using -fstack-protector-strong or falling back to -fstack-protector. I haven't put the patch up for review yet but in my opinion we should have lang/gcc be 4.9 by default before we can realistically consider an exp-run. Jason