From owner-freebsd-current@FreeBSD.ORG  Mon Jun  8 02:31:47 2015
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 87E83AE6;
 Mon,  8 Jun 2015 02:31:47 +0000 (UTC)
 (envelope-from kevlo@ns.kevlo.org)
Received: from ns.kevlo.org (220-135-115-6.HINET-IP.hinet.net [220.135.115.6])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits))
 (Client CN "ns.kevlo.org", Issuer "ns.kevlo.org" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2DB761FB9;
 Mon,  8 Jun 2015 02:31:46 +0000 (UTC)
 (envelope-from kevlo@ns.kevlo.org)
Received: from ns.kevlo.org (localhost [127.0.0.1])
 by ns.kevlo.org (8.14.9/8.14.9) with ESMTP id t582RnRQ086685
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Mon, 8 Jun 2015 10:27:49 +0800 (CST)
 (envelope-from kevlo@ns.kevlo.org)
Received: (from kevlo@localhost)
 by ns.kevlo.org (8.14.9/8.14.9/Submit) id t582RmsB086682;
 Mon, 8 Jun 2015 10:27:48 +0800 (CST) (envelope-from kevlo)
Date: Mon, 8 Jun 2015 10:27:47 +0800
From: Kevin Lo <kevlo@FreeBSD.org>
To: Gleb Smirnoff <glebius@FreeBSD.org>
Cc: Olivier =?iso-8859-1?Q?Cochard-Labb=E9?= <olivier@cochard.me>,
 current@FreeBSD.org, adrian@FreeBSD.org
Subject: Re: converted ral(4) Was: [Testers needed!] WiFi drivers changes
Message-ID: <20150608022747.GA86562@ns.kevlo.org>
References: <20150529133535.GT73119@glebius.int.ru>
 <20150604111808.GG73119@glebius.int.ru>
 <20150605031606.GA47851@ns.kevlo.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150605031606.GA47851@ns.kevlo.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Jun 2015 02:31:47 -0000

On Fri, Jun 05, 2015 at 11:16:06AM +0800, Kevin Lo wrote:
> 
> On Thu, Jun 04, 2015 at 02:18:08PM +0300, Gleb Smirnoff wrote:
> > 
> >   Hi Kevin and Olivier,
> 
> Hi Gleb,
> 
> > 
> >   you signed up as testers of ral(4). I have converted ral(4)
> > and uploaded new patch at:
> > 
> > https://reviews.freebsd.org/D2655
> > 
> > Please try, report and update the project page.
> > 
> > https://wiki.freebsd.org/projects/ifnet/net80211
> > 
> > Thanks a lot for your help.
> 
> It works fine for me.  Tested on RT5390, thanks.

As I mentioned in a private message, the diff below changes ifp->if_drv_flags
to sc->sc_flags, thanks.

--- D2655.diff.orig	2015-06-08 10:20:12.220844488 +0800
+++ D2655.diff	2015-06-08 10:20:38.020180596 +0800
@@ -6279,7 +6279,7 @@
  	RAL_LOCK_ASSERT(sc);
  
 -	KASSERT(ifp->if_drv_flags & IFF_DRV_RUNNING, ("not running"));
-+	KASSERT(ifp->if_drv_flags & RAL_RUNNING, ("not running"));
++	KASSERT(sc->sc_flags & RAL_RUNNING, ("not running"));
  
  	if (sc->sc_invalid)		/* card ejected */
  		return;
@@ -7109,7 +7109,7 @@
  	RAL_LOCK_ASSERT(sc);
  
 -	KASSERT(ifp->if_drv_flags & IFF_DRV_RUNNING, ("not running"));
-+	KASSERT(ifp->if_drv_flags & RT2860_RUNNNING, ("not running"));
++	KASSERT(sc->sc_flags & RT2860_RUNNNING, ("not running"));
  
  	if (sc->sc_invalid)		/* card ejected */
  		return;