From owner-freebsd-hackers Sun Dec 6 08:50:44 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id IAA14066 for freebsd-hackers-outgoing; Sun, 6 Dec 1998 08:50:44 -0800 (PST) (envelope-from owner-freebsd-hackers@FreeBSD.ORG) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id IAA14061; Sun, 6 Dec 1998 08:50:42 -0800 (PST) (envelope-from j@uriah.heep.sax.de) Received: (from uucp@localhost) by sax.sax.de (8.8.8/8.8.8) with UUCP id RAA14250; Sun, 6 Dec 1998 17:50:35 +0100 (CET) (envelope-from j@uriah.heep.sax.de) Received: (from j@localhost) by uriah.heep.sax.de (8.9.1/8.9.1) id RAA14848; Sun, 6 Dec 1998 17:27:45 +0100 (MET) (envelope-from j) Message-ID: <19981206172744.53389@uriah.heep.sax.de> Date: Sun, 6 Dec 1998 17:27:44 +0100 From: J Wunsch To: freebsd-hackers@FreeBSD.ORG, cvs-committers@FreeBSD.ORG Subject: Re: getting to -Wunused Reply-To: Joerg Wunsch References: <199812060032.QAA01400@bubba.whistle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.88 In-Reply-To: <199812060032.QAA01400@bubba.whistle.com>; from Archie Cobbs on Sat, Dec 05, 1998 at 04:32:44PM -0800 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG As Archie Cobbs wrote: > (d) Static functions that are declared and defined, but never used: > > (i) Some of these are defined #ifdef DDB, and are clearly meant > for debugging purposes (they're not used, but they're handy > to call from the debugger to print out stuff, etc). These > are "legitimate" unused functions. I think those should not be defined `static'. If they are meant to be called from within DDB, it's necessary to maintain a globally unique function name anyway, so why having it `static'? (Of course, the function remains in an `apparently unsued' state, but for a non-static function, the compiler should be silent for this.) -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message