From owner-freebsd-bugs@FreeBSD.ORG  Fri Apr  3 21:49:25 2015
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 2D6554CB
 for <freebsd-bugs@FreeBSD.org>; Fri,  3 Apr 2015 21:49:25 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 139A483D
 for <freebsd-bugs@FreeBSD.org>; Fri,  3 Apr 2015 21:49:25 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t33LnO9t067830
 for <freebsd-bugs@FreeBSD.org>; Fri, 3 Apr 2015 21:49:24 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 199152] msdosfs writes on umount to readonly mounted fs
Date: Fri, 03 Apr 2015 21:49:25 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 10.1-STABLE
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: longwitz@incore.de
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
 attachments.created
Message-ID: <bug-199152-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Apr 2015 21:49:25 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199152

            Bug ID: 199152
           Summary: msdosfs writes on umount to readonly mounted fs
           Product: Base System
           Version: 10.1-STABLE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: longwitz@incore.de

Created attachment 155169
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=155169&action=edit
Patch for msdosfs

In FreeBSD 10.1-STABLE #10 r279940 I see

mount -r /mydosfs
umount /mydosfs
umount: unmount of /mydosfs failed: Operation not permitted
On console: g_vfs_done():ada0p1[WRITE(offset=512, length=512)]error = 1

The next umount works.

This problem was introduced by rev 275638 to head, because in the case of a
readonly mounted msdosfs a call of msdosfs_sync() was introduced which failes
to write in msdos_fsiflush(). This happens because the flag MSDOSFS_FSIMOD is
set on the first call of msdosfs_sync().

The attached patch solves the problem for me and includes also some minor
changes necessary to build the kernel with MSDOS_DEBUG.

-- 
You are receiving this mail because:
You are the assignee for the bug.