From owner-svn-src-all@freebsd.org Fri Dec 4 12:43:06 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B26E8A40AC5; Fri, 4 Dec 2015 12:43:06 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail110.syd.optusnet.com.au (mail110.syd.optusnet.com.au [211.29.132.97]) by mx1.freebsd.org (Postfix) with ESMTP id 78E0D1237; Fri, 4 Dec 2015 12:43:06 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c211-30-166-197.carlnfd1.nsw.optusnet.com.au (c211-30-166-197.carlnfd1.nsw.optusnet.com.au [211.30.166.197]) by mail110.syd.optusnet.com.au (Postfix) with ESMTPS id 9A5F5781027; Fri, 4 Dec 2015 23:42:57 +1100 (AEDT) Date: Fri, 4 Dec 2015 23:42:51 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Bryan Drewery cc: "Kenneth D. Merry" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291741 - head/sys/geom In-Reply-To: <56610B6B.8010708@FreeBSD.org> Message-ID: <20151204233052.J2220@besplex.bde.org> References: <201512040338.tB43cZY1053263@repo.freebsd.org> <56610B6B.8010708@FreeBSD.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.1 cv=R4L+YolX c=1 sm=1 tr=0 a=KA6XNC2GZCFrdESI5ZmdjQ==:117 a=PO7r1zJSAAAA:8 a=JzwRw_2MAAAA:8 a=kj9zAlcOel0A:10 a=QKBkEAZcdmDwnr26A94A:9 a=CjuIK1q_8ugA:10 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 12:43:06 -0000 On Thu, 3 Dec 2015, Bryan Drewery wrote: > On 12/3/2015 7:38 PM, Kenneth D. Merry wrote: >> g_disk_limit(struct disk *dp, struct bio *bp) >> { >> bool limited = false; >> - off_t d_maxsize; >> - >> - d_maxsize = (bp->bio_cmd == BIO_DELETE) ? >> - dp->d_delmaxsize : dp->d_maxsize; >> + off_t maxsz = g_disk_maxsize(dp, bp); > > This looks like a style issue. This looks like 5 style bugs and 0 issues: 3 old style bugs: - use of bool - initialization in declaration - unsorted declarations 2 new style bugs: - another initialization in declaration. A larger one - lost blank line after declarations. sys/geom had no instances of the bool style bug as recently as last month. At the top level, it didn't even use boolean_t. In subdirectories, it used boolean_t on 33 lines. Bruce