From owner-freebsd-ports@FreeBSD.ORG Fri Feb 5 00:07:49 2010 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4DE2F106566C for ; Fri, 5 Feb 2010 00:07:49 +0000 (UTC) (envelope-from 000.fbsd@quip.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) by mx1.freebsd.org (Postfix) with ESMTP id 107DA8FC13 for ; Fri, 5 Feb 2010 00:07:48 +0000 (UTC) Received: from elsa.codelab.cz (localhost.codelab.cz [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id CCFF819E023; Fri, 5 Feb 2010 01:07:46 +0100 (CET) Received: from [192.168.1.2] (r5bb235.net.upc.cz [86.49.61.235]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id 8F63A19E019; Fri, 5 Feb 2010 01:07:44 +0100 (CET) Message-ID: <4B6B614F.9080107@quip.cz> Date: Fri, 05 Feb 2010 01:07:43 +0100 From: Miroslav Lachman <000.fbsd@quip.cz> User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1.7) Gecko/20100104 SeaMonkey/2.0.2 MIME-Version: 1.0 To: decke@bluelife.at Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 7bit Cc: "freebsd-ports@FreeBSD.org" Subject: Redmine files not executable, but log files are executable X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Feb 2010 00:07:49 -0000 Hi, I am new to installation of www/redmine from ports. I am surprised that all redmine files are not executable. Including files which should be executed by startup script etc. (I mean files in script/ directory, mainly script/server) These files are executables in the original source tar archive. What is more surprising is that after reinstall or upgrade of redmine, there are executable bits set on logfiles, because of recursive chmod in redmine/Makefile: .for f in files log tmp public/plugin_assets ${CHMOD} -R 755 ${WWWDIR}/${f} .endfor redmine/# find . -type f -perm +0111 -ls 321080 2 -rwxr-xr-x 1 www www 374 May 28 2009 ./public/plugin_assets/README 14111 2 -rwxr-xr-x 1 www www 36 Sep 13 14:10 ./files/delete.me 321079 2 -rwxr-xr-x 1 www www 51 May 28 2009 ./log/production.log 14119 2 -rwxr-xr-x 1 www www 36 Sep 13 14:10 ./log/delete.me I know that the first problem is caused by COPYTREE_SHARE in do-install: and I am asking if it is really necesarry to have all files set to 0444, I think those few files should be installed executable as in the original archive. And chmod for directories should be not recursive to not set executable bits on files from previous installation. So my proposal is use chmod without -R on directories only: .for f in files log tmp tmp/cache tmp/sessions tmp/sockets public/plugin_assets ${CHMOD} 755 ${WWWDIR}/${f} .endfor And to set 0554 on files in scripts/ directory .for f in about breakpointer console destroy generate plugin runner server ${CHMOD} 0555 ${WWWDIR}/script/${f} .endfor (and maybe some files in script/performance + script/process too) What you think about that? Miroslav Lachman