Date: Thu, 12 Jan 2012 23:17:26 +0200 From: Mikolaj Golub <trociny@freebsd.org> To: "Robert N. M. Watson" <rwatson@freebsd.org> Cc: Kostik Belousov <kib@freebsd.org>, freebsd-arch@freebsd.org Subject: Re: unix domain sockets on nullfs(5) Message-ID: <CAOnPXZ_y5G6uEBWmfuH7qYBh%2B4Pw=O91ztCPEFCOTzWdCzx%2BRA@mail.gmail.com> In-Reply-To: <86fwfnti5t.fsf@kopusha.home.net> References: <86sjjobzmn.fsf@kopusha.home.net> <D1B8F00C-1E0D-4916-BD4B-FBCAE28E6F22@FreeBSD.org> <86fwfnti5t.fsf@kopusha.home.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 10, 2012 at 10:30 PM, Mikolaj Golub <trociny@freebsd.org> wrote: > > On Tue, 10 Jan 2012 14:02:34 +0000 Robert N. M. Watson wrote: > > RNMW> (1) I don't think the new behaviour should be optional -- it was always > RNMW> the intent that nullfs pass through all behaviours to the underlying > RNMW> layer, it's just that certain edge cases didn't appear in the original > RNMW> implementation. Memory mapping was fixed a few years ago using similar > RNMW> techniques. This will significantly reduce the complexity of your > RNMW> patch, and also avoid user confusion since it will now behave "as > RNMW> expected". Certainly, mention in future release notes would be > RNMW> appropriate, however. > > I don't mind having only the new behavior, as I can't imagine where I would > need a nullfs with nosobypass option mounted and I also like when things are > simple :-). > > On the other hand there might be people who relied on the old behavior and who > would be surprised if it had changed. > > So, if other people agree I will remove the old behaviour to make the patch > simpler. Another option would be to have sobypass by default with possibility > to (re)mount fs with nosobypass. > If we agree to have only the new behavior then nullfs won't need modification at all, it will work as expected automatically. The patch could be (with updated locking for the connect case): http://people.freebsd.org/~trociny/VOP_UNP.1.patch
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOnPXZ_y5G6uEBWmfuH7qYBh%2B4Pw=O91ztCPEFCOTzWdCzx%2BRA>