From owner-dev-commits-src-all@freebsd.org Fri Feb 19 00:00:33 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0CE9652F658 for ; Fri, 19 Feb 2021 00:00:33 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DhWtS6fzcz4XTd for ; Fri, 19 Feb 2021 00:00:32 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wm1-f47.google.com with SMTP id o24so5389428wmh.5 for ; Thu, 18 Feb 2021 16:00:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=I7anpkyQpMVIEdOjiatkXB1W4lymEII/ZwjO5jc7Z1Q=; b=U8odp/lCEnwLcV+OagDNypU9f6Uv3I6eW7+4WvICou1kvlCC6Exm60wKHwDhSqaOXD htEQ/Q/jccT2M7FgVcH8yn1XR4A/PQCiikRi47QLpZnwLntIQFyxjB7zRGBn/VBMQ6C8 rjVcwbTNZEewquKAdASh74NthCh08WR+vaBoeLpLLiGMT9KhnwxVmaLr1X50nUkD0jhO vJz1ljiwaWtQFlBC7tqnYGsf3Or4NcL89YddeGfcix8CGUwQrm6ddvWxQA/WlXYpkEwo MbyBe1BQbWtZXerTRn0SCY3Lo4QS+9+k6nuk/b9ESVrF9lRVldACZjQF4Byq5l9ExER8 0LLg== X-Gm-Message-State: AOAM530CaG+qFOhhQMzl69pe9Nzg6Dif8cyDErnWSD0O+sfk6mPEzG4C rR1WlZ12e+J1NooVcc7vj8d5Rw== X-Google-Smtp-Source: ABdhPJx8lLHo0pXKNKocaL58ks3bxQasPWvnPwm3aWEIPoL6Xuz4eCESrcJPFMMg2LcyZBoL76M34Q== X-Received: by 2002:a1c:730a:: with SMTP id d10mr5494381wmb.53.1613692830391; Thu, 18 Feb 2021 16:00:30 -0800 (PST) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id b2sm11645770wrn.2.2021.02.18.16.00.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Feb 2021 16:00:30 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: git: 24fd63e0970f - main - mips: Don't set __NO_TLS to disable some uses of TLS. From: Jessica Clarke In-Reply-To: Date: Fri, 19 Feb 2021 00:00:27 +0000 Cc: Konstantin Belousov , John Baldwin , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <3045F222-DBAC-463C-B429-075B2CFB115A@freebsd.org> References: <202102180035.11I0ZnL3070354@gitrepo.freebsd.org> <9687575c-dd7c-1496-850b-2018f4bca3da@FreeBSD.org> To: Brandon Bergren X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4DhWtS6fzcz4XTd X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2021 00:00:33 -0000 On 18 Feb 2021, at 23:57, Brandon Bergren wrote: > On Thu, Feb 18, 2021, at 3:07 PM, Jessica Clarke wrote: >>> But, I wonder, what does CALL_ELF mean? Is it for old 64bit PowerPC = ABI, >>> that was abandoned with the switch to ELFv2? >>=20 >> Yes, _CALL_ELF =3D=3D 2 for ELFv2. I highly doubt the defines were = needed >> for the ELFv1 ABI, but they're especially redundant now. Presumably >> David's original fixed commit[1] added powerpc64 to that list because >> TLS wasn't yet supported in LLVM; that happened later in 2012 and our >> wiki changed it to being implemented in December 2012[2]. So I = suspect >> it should have been deleted 8 years ago. >=20 > FreeBSD 13 will be the first ELFv2 release. FreeBSD 12 and below are = ELFv1. >=20 > The reason for the line was to avoid breaking things during the = development period for ELFv2. Switching TLS on was one of the things I = did at the same time as the official ELFv2 transition. See = 2db975b0eb0f3378a39d63eeabe4e3617f4557f0. >=20 > This is NOT an 8 year old change, but I believe it can go away in HEAD = as long as the change isn't MFC'd to 12 or earlier. But TLS isn't broken for ELFv1? Otherwise jemalloc would die in a fire and nothing would ever work. TLS should have been working for ELFv1 for many years by this point. Jess