From nobody Fri Apr 29 21:57:02 2022 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 65ADC1AAE554 for ; Fri, 29 Apr 2022 21:57:30 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from land.berklix.org (land.berklix.org [144.76.10.75]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "land.berklix.org", Issuer "land.berklix.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KqmYj2d6xz3m9d; Fri, 29 Apr 2022 21:57:29 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from mart.js.berklix.net (p4fe6d03e.dip0.t-ipconnect.de [79.230.208.62]) (authenticated bits=128) by land.berklix.org (8.16.1/8.16.1) with ESMTPSA id 23TLvHLK082836 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 29 Apr 2022 21:57:21 GMT (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41]) by mart.js.berklix.net (8.14.3/8.14.3) with ESMTP id 23TLvCKD049920; Fri, 29 Apr 2022 23:57:12 +0200 (CEST) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (localhost [127.0.0.1]) by fire.js.berklix.net (8.14.7/8.14.7) with ESMTP id 23TLv232063233; Fri, 29 Apr 2022 23:57:12 +0200 (CEST) (envelope-from jhs@berklix.com) Message-Id: <202204292157.23TLv232063233@fire.js.berklix.net> To: Ed Maste cc: FreeBSD-STABLE Mailing List Subject: Re: breaking modules From: "Julian H. Stacey" Organization: http://berklix.com/jhs/ User-agent: EXMH on FreeBSD http://berklix.com/free/ X-From: http://www.berklix.org/~jhs/ In-reply-to: Your message "Fri, 29 Apr 2022 10:49:04 -0400." Date: Fri, 29 Apr 2022 23:57:02 +0200 X-Rspamd-Queue-Id: 4KqmYj2d6xz3m9d X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of jhs@berklix.com has no SPF policy when checking 144.76.10.75) smtp.mailfrom=jhs@berklix.com X-Spamd-Result: default: False [-1.13 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FREEFALL_USER(0.00)[jhs]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.996]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[berklix.com]; AUTH_NA(1.00)[]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; NEURAL_HAM_MEDIUM(-0.94)[-0.938]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.10)[-0.102]; RCPT_COUNT_TWO(0.00)[2]; MLMMJ_DEST(0.00)[freebsd-stable]; R_SPF_NA(0.00)[no SPF record]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:144.76.0.0/16, country:DE]; RCVD_TLS_LAST(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[79.230.208.62:received] X-ThisMailContainsUnwantedMimeParts: N List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org Ed Maste wrote: > On Thu, 28 Apr 2022 at 11:28, Julian H. Stacey wrote: > > > > but that's crude. It's nice to be able to build most modules ready > > in case wanted later, so how about a DUDS env. mechanism like ports/ ? > > I'd rather not add additional complexity to our build infrastructure > to address a situation that shouldn't exist. Modules should build & > function on an ongoing basis (and, I believe they generally do). CI > doesn't report any issues on either stable branch or main at present. I'm building stable-12 not stable-13. It's broken here. I've seen modules break for years, I used to suspect modules werent built by default by build engines as often as main src/, so modules had more time to rot against changing includes & libs, maybe now build engines might compile them as often as eg bin/ls/ ? I don't know; But I'm seeing modules breaks. I just refetched with git this mid Friday afternoon (TZ=+02:00) 12.3-STABLE & the 2 breaks are still present. See below. Setting a MODULE_DUDS would save work rather than repetitively retro patching out the same modules in Makefile after each git pull --ff-only. I'd happily develop a patch for sys/modules/, but if someone else prefers to, that might increase the chance of it being commited. I'd be happy to test or develop a fix for sys/modules/Makefile. ------- 12.3-STABLE /dev/pts/6 jhs 15 lapr/data/release/s2/usr/src/sys/modules/randomrtuna make cc -O2 -pipe -fno-common -DRANDOM_LOADABLE -fno-strict-aliasing -Werror -D_NEL -DKLD_MODULE -nostdinc -I. -I/data/release/s2/usr/src/sys -I/data/releas2/usr/src/sys/contrib/ck/include -fno-common -fno-omit-frame-pointer -mno-o-leaf-frame-pointer -fdebug-prefix-map=./machine=/data/release/s2/usr/src/sysd64/include -fdebug-prefix-map=./x86=/data/release/s2/usr/src/sys/x86/include-MD -MF.depend.randomdev.o -MTrandomdev.o -mcmodel=kernel -mno-red-zone -mnox -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fwra-fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypeWmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D_intf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option --unknown-pragmas -Wno-error=tautological-compare -Wno-error=empty-body -Wno-er=parentheses-equality -Wno-error=unused-function -Wno-error=pointer-sign -Wnrror=shift-negative-value -Wno-address-of-packed-member -Wno-erro! r=unused-butt-variable -Wno-format-zero-length -mno-aes -mno-avx -std=iso9899:1999 -c /a/release/s2/usr/src/sys/dev/random/randomdev.c -o randomdev.o /data/release/s2/usr/src/sys/dev/random/randomdev.c:70:13: error: conflictingpes for 'read_random_uio' static int (read_random_uio)(struct uio *, bool); ^ /data/release/s2/usr/src/sys/sys/random.h:73:1: note: previous definition is e read_random_uio(void *a __unused, u_int b __unused) ^ /data/release/s2/usr/src/sys/dev/random/randomdev.c:96:2: error: use of undeced identifier '_read_random_uio' _read_random_uio = (read_random_uio); ^ /data/release/s2/usr/src/sys/dev/random/randomdev.c:97:2: error: use of undeced identifier '_read_random' _read_random = (read_random); ^ /data/release/s2/usr/src/sys/dev/random/randomdev.c:98:2: error: use of undeced identifier '_is_random_seeded' _is_random_seeded = (is_random_seeded); ^ /data/release/s2/usr/src/sys/dev/random/randomdev.c:160:2: error: conflictingpes for 'read_random_uio' (read_random_uio)(struct uio *uio, bool nonblock) ^ /data/release/s2/usr/src/sys/sys/random.h:73:1: note: previous definition is e read_random_uio(void *a __unused, u_int b __unused) ^ /data/release/s2/usr/src/sys/dev/random/randomdev.c:261:2: error: redefinitiof 'read_random' (read_random)(void *random_buf, u_int len) ^ /data/release/s2/usr/src/sys/sys/random.h:78:1: note: previous definition is e read_random(void *a __unused, u_int b __unused) ^ /data/release/s2/usr/src/sys/dev/random/randomdev.c:295:2: error: redefinitiof 'is_random_seeded' (is_random_seeded)(void) ^ /data/release/s2/usr/src/sys/sys/random.h:82:1: note: previous definition is e is_random_seeded(void) ^ 7 errors generated. *** Error code 1 Stop. make: stopped in /data/release/s2/usr/src/sys/modules/random_fortuna ------- 12.3-STABLE /dev/pts/6 jhs 21 lapr/data/release/s2/usr/src/sys/modules/random_other make cc -O2 -pipe -fno-common -DRANDOM_LOADABLE -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I. -I/data/release/s2/usr/src/sys -I/data/release/s2/usr/src/sys/contrib/ck/include -fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/data/release/s2/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/data/release/s2/usr/src/sys/x86/include -MD -MF.depend.randomdev.o -MTrandomdev.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error=tautological-compare -Wno-error=empty-body -Wno-error=parentheses-equality -Wno-error=unused-function -Wno-error=pointer-sign -Wno-error=shift-negative-value -Wn! o-address-of-packed-member -Wno-error=unused-but-set-variable -Wno-format-zero-length -mno-aes -mno-avx -std=iso9899:1999 -c /data/release/s2/usr/src/sys/dev/random/randomdev.c -o randomdev.o /data/release/s2/usr/src/sys/dev/random/randomdev.c:70:13: error: conflicting types for 'read_random_uio' static int (read_random_uio)(struct uio *, bool); ^ /data/release/s2/usr/src/sys/sys/random.h:73:1: note: previous definition is here read_random_uio(void *a __unused, u_int b __unused) ^ /data/release/s2/usr/src/sys/dev/random/randomdev.c:96:2: error: use of undeclared identifier '_read_random_uio' _read_random_uio = (read_random_uio); ^ /data/release/s2/usr/src/sys/dev/random/randomdev.c:97:2: error: use of undeclared identifier '_read_random' _read_random = (read_random); ^ /data/release/s2/usr/src/sys/dev/random/randomdev.c:98:2: error: use of undeclared identifier '_is_random_seeded' _is_random_seeded = (is_random_seeded); ^ /data/release/s2/usr/src/sys/dev/random/randomdev.c:160:2: error: conflicting types for 'read_random_uio' (read_random_uio)(struct uio *uio, bool nonblock) ^ /data/release/s2/usr/src/sys/sys/random.h:73:1: note: previous definition is here read_random_uio(void *a __unused, u_int b __unused) ^ /data/release/s2/usr/src/sys/dev/random/randomdev.c:261:2: error: redefinition of 'read_random' (read_random)(void *random_buf, u_int len) ^ /data/release/s2/usr/src/sys/sys/random.h:78:1: note: previous definition is here read_random(void *a __unused, u_int b __unused) ^ /data/release/s2/usr/src/sys/dev/random/randomdev.c:295:2: error: redefinition of 'is_random_seeded' (is_random_seeded)(void) ^ /data/release/s2/usr/src/sys/sys/random.h:82:1: note: previous definition is here is_random_seeded(void) ^ 7 errors generated. *** Error code 1 Stop. make: stopped in /data/release/s2/usr/src/sys/modules/random_other ------- Cheers, -- Julian Stacey http://berklix.com/jhs/ http://StolenVotes.UK Kill / remove Putin: He kills innocents & causes global grain & fuel shortage.