From owner-svn-src-head@freebsd.org Tue Oct 1 22:13:27 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A5C4AF9D62; Tue, 1 Oct 2019 22:13:27 +0000 (UTC) (envelope-from brd@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46jYSR3x27z4T9y; Tue, 1 Oct 2019 22:13:27 +0000 (UTC) (envelope-from brd@FreeBSD.org) Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com [66.111.4.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: brd/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4DB4D49CC; Tue, 1 Oct 2019 22:13:27 +0000 (UTC) (envelope-from brd@FreeBSD.org) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailauth.nyi.internal (Postfix) with ESMTP id D135122243; Tue, 1 Oct 2019 18:13:26 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute5.internal (MEProxy); Tue, 01 Oct 2019 18:13:26 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrgeehgddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvffutgesthdtre dtreertdenucfhrhhomhepfdeurhgrugcuffgrvhhishdfuceosghrugeshfhrvggvuefu ffdrohhrgheqnecuffhomhgrihhnpehfrhgvvggsshgurdhorhhgnecurfgrrhgrmhepmh grihhlfhhrohhmpegsrhgrugdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidq jedtjeeifedvfedvqddukedtieelieekkedqsghrugeppefhrhgvvgeuufffrdhorhhgse hsohdugehkrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 846C4E00A6; Tue, 1 Oct 2019 18:13:26 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-334-g7f5110b-fmstable-20191001v2 Mime-Version: 1.0 Message-Id: <680b08c2-10d7-4080-9170-e5d71cafacd0@www.fastmail.com> In-Reply-To: <201909061425.x86EPfno078236@repo.freebsd.org> References: <201909061425.x86EPfno078236@repo.freebsd.org> Date: Tue, 01 Oct 2019 16:12:41 -0600 From: "Brad Davis" To: "Randall Stewart" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r351934 - in head/sys: netinet netinet/tcp_stacks sys Content-Type: text/plain X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Oct 2019 22:13:27 -0000 On Fri, Sep 6, 2019, at 8:25 AM, Randall Stewart wrote: > Author: rrs > Date: Fri Sep 6 14:25:41 2019 > New Revision: 351934 > URL: https://svnweb.freebsd.org/changeset/base/351934 > > Log: > This adds the final tweaks to LRO that will now allow me > to add BBR. These changes make it so you can get an > array of timestamps instead of a compressed ack/data segment. > BBR uses this to aid with its delivery estimates. We also > now (via Drew's suggestions) will not go to the expense of > the tcb lookup if no stack registers to want this feature. If > HPTS is not present the feature is not present either and you > just get the compressed behavior. Hi Randall, This (+ the fixes in r351950, r351951, r351952) break TCP over a VLAN interface for me. 15:57:27.437022 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto TCP (6), length 64) 192.168.1.247.51621 > 192.168.1.31.22: Flags [S], cksum 0x829c (correct), seq 954393965, win 65535, options [mss 1460,nop,wscale 6,nop,nop,TS val 1140851693 ecr 0,sackOK,eol], length 0 15:57:27.437055 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto TCP (6), length 60, bad cksum 0 (->b655)!) 192.168.1.31.22 > 192.168.1.247.51621: Flags [S.], cksum 0x8495 (incorrect -> 0x7d08), seq 532354280, ack 954393966, win 65535, options [mss 1460,nop,wscale 6,sackOK,TS val 1641644043 ecr 1140851693], length 0 15:57:27.449358 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto TCP (6), length 90, bad cksum 0 (->b637)!) 192.168.1.31.22 > 192.168.1.247.51621: Flags [P.], cksum 0x84b3 (incorrect -> 0xe69e), seq 1:39, ack 1, win 1026, options [nop,nop,TS val 1641644055 ecr 1140851693], length 38 15:58:00.363155 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto TCP (6), length 52, bad cksum 0 (->b65d)!) 192.168.1.31.22 > 192.168.1.247.51619: Flags [.], cksum 0x848d (incorrect -> 0x98dd), seq 733444611, ack 2137820470, win 1026, options [nop,nop,TS val 3639423932 ecr 1140820150], length 0 15:58:30.078521 IP (tos 0x0, ttl 64, id 0, offset 0, flags [DF], proto TCP (6), length 52, bad cksum 0 (->b65d)!) 192.168.1.31.22 > 192.168.1.247.51621: Flags [.], cksum 0x848d (incorrect -> 0xb2f9), seq 39, ack 1, win 1026, options [nop,nop,TS val 1641706684 ecr 1140851693], length 0 Disabling LRO fixes it. Let me know if I can provide any more information. Thanks, Brad Davis