From owner-svn-src-head@freebsd.org  Tue Dec 26 16:00:00 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id EF76CE9E2BA;
 Tue, 26 Dec 2017 16:00:00 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id CFB807AD71;
 Tue, 26 Dec 2017 16:00:00 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 0CE40311C; Tue, 26 Dec 2017 16:00:00 +0000 (UTC)
Date: Tue, 26 Dec 2017 16:00:00 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Michael Tuexen <tuexen@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r327205 - head/sys/netinet/libalias
Message-ID: <20171226160000.GB90333@FreeBSD.org>
References: <201712261524.vBQFOggM046909@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201712261524.vBQFOggM046909@repo.freebsd.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Dec 2017 16:00:01 -0000

On Tue, Dec 26, 2017 at 03:24:42PM +0000, Michael Tuexen wrote:
> New Revision: 327205
> URL: https://svnweb.freebsd.org/changeset/base/327205
> 
> Log:
>   Fix CID 1008936.

I'm afraid this is a rather bad commit message.  It should have described
what was the problem and how it was approached (fixed).  Listing CID is
part of the metadata; it cannot replace proper commit log.

Also, please do not mix functional and substantial amount of style changes
in a single commit.

./danfe