From owner-cvs-usrbin Fri Apr 25 06:44:31 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id GAA15881 for cvs-usrbin-outgoing; Fri, 25 Apr 1997 06:44:31 -0700 (PDT) Received: from nagual.pp.ru (ache.relcom.ru [194.58.229.133]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id GAA15728; Fri, 25 Apr 1997 06:40:50 -0700 (PDT) Received: (from ache@localhost) by nagual.pp.ru (8.8.5/8.8.5) id RAA02901; Fri, 25 Apr 1997 17:37:07 +0400 (MSD) Date: Fri, 25 Apr 1997 17:37:04 +0400 (MSD) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= To: Bruce Evans cc: cvs-all@FreeBSD.org, CVS-committers@FreeBSD.org, cvs-usrbin@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/vacation vacation.c In-Reply-To: <199704251158.VAA28172@godzilla.zeta.org.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-usrbin@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk On Fri, 25 Apr 1997, Bruce Evans wrote: > >So, right now we already have some sort of this support by default > >based on current gcc behaviour. If this behaviour will be changed (more > >general case you speak about), such compiler must support vfork > >especially, i.e. not cross-optimizing, keeping stack frame, etc. > > I just noticed that gcc already has some support. Put back the vfork() > in mount.c and compile with -Wall, and you will see the useful warnings > that `optbuf' and `name' might be clobbered by `longjmp' or `vfork'. It has more support than just a warnings, vfork calling function marked and processed in the same way as setjmp calling function now (returns twice). It looks like noop right now because we not turn NON_SAVING_SETJMP define on. Perhaps we should turn it off for setjmp() and on for vfork() separately. -- Andrey A. Chernov http://www.nagual.pp.ru/~ache/