From owner-freebsd-current@freebsd.org Thu Jul 25 19:10:47 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DA539AC19B; Thu, 25 Jul 2019 19:10:47 +0000 (UTC) (envelope-from ler@FreeBSD.org) Received: from thebighonker.lerctr.org (ns-b.lerctr.org [IPv6:2001:470:1f0f:3ad::53:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "*.lerctr.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B131E90F26; Thu, 25 Jul 2019 19:10:47 +0000 (UTC) (envelope-from ler@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lerctr.org; s=ler2019; h=Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: Content-Transfer-Encoding:Content-Type:MIME-Version:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6a9e4Lcu43qPZSW5BfbIEI+qUkAmu2/P28lfvsXxAbY=; b=OIdf6ww7frYsveVu5QrA+L5W0t 4wfhd8BuYmKDzDKqhXcZsIJ+6JGQDIsb752yTIuvhQE6VcPFPQAAtxQpr459htfJjfJfqBLhi83jl pmO4yjCDsV/xq8ttIbDrpTMLfM0jypc+k94HsSbcbAvfJjU30xmLFQRB7S1Vpcb0aZwm/EBH5U75Q Jo6MpGlXpGfFvXj1VG/2VggTaV22YhqwCuliwHlH0JqUrix/V8loCFVIBIPpyFyx0l/cy2xeXr330 MAZ3ruOWhtPImt4oe+xlwgaYvQ9WoAdVKD0wrvBr0x1earp4u+43i1tn1Ypom7Lf49ZlO4zM7FgtZ +TzUmnFQ==; Received: from thebighonker.lerctr.org ([2001:470:1f0f:3ad:bb:dcff:fe50:d900]:47871 helo=webmail.lerctr.org) by thebighonker.lerctr.org with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92 (FreeBSD)) (envelope-from ) id 1hqj8Y-0004se-9H; Thu, 25 Jul 2019 14:10:46 -0500 Received: from 2600:1700:210:b180:f4ae:ab2e:e462:6b19 by webmail.lerctr.org with HTTP (HTTP/1.1 POST); Thu, 25 Jul 2019 14:10:46 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 25 Jul 2019 14:10:46 -0500 From: Larry Rosenman To: Justin Hibbits Cc: Alan Somers , Freebsd current , owner-freebsd-current@freebsd.org Subject: Re: [package - head-i386-default][sysutils/lsof] Failed for lsof-4.93.2_2,8 in build In-Reply-To: <20190725134017.7c09692d@titan.knownspace> References: <201907251750.x6PHoAsV025165@beefy11.nyi.freebsd.org> <20190725134017.7c09692d@titan.knownspace> Message-ID: <6aa1650d276c1622ea9d66c2abe775a8@FreeBSD.org> X-Sender: ler@FreeBSD.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jul 2019 19:10:47 -0000 On 07/25/2019 1:40 pm, Justin Hibbits wrote: > On Thu, 25 Jul 2019 12:35:32 -0600 > Alan Somers wrote: > >> On Thu, Jul 25, 2019 at 12:13 PM Larry Rosenman >> wrote: >> > >> > On 07/25/2019 1:10 pm, Alan Somers wrote: >> > > On Thu, Jul 25, 2019 at 12:05 PM Larry Rosenman >> > > wrote: >> > >> >> > >> Um.... Who broke this? > ... >> > > "svn blame" suggests r350199 by kib. However, refcount.h should >> > > only be included if lsof defines _KERNEL, which normal programs >> > > shouldn't. So I think this should be considered a bug in lsof. >> > > -Alan >> > >> > >> > we *HAVE* to define _KERNEL, to get at the kernel structures..... >> >> Then I think you have to live with this amount of instability. >> refcount(9) says that you should include . Did you do >> that? If so, then this is a man page bug and refcount(9) should also >> specify stdbool.h. >> -Alan > > includes already, which typedefs bool. So > should suffice to include in lsof. > > - Justin > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to > "freebsd-current-unsubscribe@freebsd.org" Thanks all! I've got a PR into the lsof repo, and I'll fix it there. If we can't get a release out in the next day or 2, I'll patch it in the port. https://github.com/lsof-org/lsof/pull/70 -- Larry Rosenman http://people.freebsd.org/~ler Phone: +1 214-642-9640 E-Mail: ler@FreeBSD.org US Mail: 5708 Sabbia Dr, Round Rock, TX 78665-2106