From owner-cvs-src@FreeBSD.ORG Thu Jul 12 06:46:55 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4B23B16A421; Thu, 12 Jul 2007 06:46:55 +0000 (UTC) (envelope-from brians@ca.sophos.com) Received: from lightroast.ca.sophos.com (gw.ca.sophos.com [209.17.183.249]) by mx1.freebsd.org (Postfix) with ESMTP id 0F08813C448; Thu, 12 Jul 2007 06:46:54 +0000 (UTC) (envelope-from brians@ca.sophos.com) Received: from smtp3.ca.sophos.com (smtp3.ca.sophos.com [192.168.3.19]) by lightroast.ca.sophos.com (8.13.8/8.13.8) with ESMTP id l6C6kqFY013113; Wed, 11 Jul 2007 23:46:52 -0700 (PDT) (envelope-from brians@ca.sophos.com) Received: from dev.lan.Awfulhak.org (ssh1.ActiveState.com [192.168.3.32]) by smtp.ca.sophos.com (8.13.4/8.13.4) with ESMTP id l6C6kpuf020335; Wed, 11 Jul 2007 23:46:51 -0700 (envelope-from brians@ca.sophos.com) Date: Wed, 11 Jul 2007 23:46:51 -0700 From: Brian Somers To: mjacob@FreeBSD.org Message-ID: <20070711234651.5efc1c66@dev.lan.Awfulhak.org> In-Reply-To: <20070706190843.X78793@ns1.feral.com> References: <200707070054.l670slr1007427@repoman.freebsd.org> <20070706183517.512b6dab@conflict> <20070706190843.X78793@ns1.feral.com> Organization: Sophos X-Mailer: Claws Mail 2.10.0 (GTK+ 2.10.13; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-PerlMx-Spam: CA, Deliver, Gauge=IIIIIII, Probability=7%, Report='__C230066_P5 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __SANE_MSGID 0' X-SpamReport: No antispam rules were triggered by this message X-PMX-Version: CA 5.3.2.304607, Antispam-Engine: 2.5.1.298604, Antispam-Data: 2007.7.11.232533 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Brian Somers , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if.c if_var.h src/sys/netinet in.c in_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2007 06:46:55 -0000 On Fri, 6 Jul 2007 19:08:57 -0700 (PDT) mjacob@FreeBSD.org wrote: > > Cool. Can we put this in regression tests? To be honest, I've never looked in tools/regression... until now. It looks like a bit of a mess. According to the README (last updated in 2001) it should be possible to ``prove -r'' everything. This is far from true, so forgive me for ranting if I've got the wrong end of the stick. Here's what I'd expect: - ``prove -r'' works - ``make test'' works in a similar way to ``prove -r'', sets PATH to /usr/obj/... and fails if tests fail. - .t files build test programs as required. - .t files skip() tests (or plan a different number) when required resources aren't available. - comments on ok/not ok lines are mandatory It would also be nice to bring libtap into the base system. If there are no objections, I'll look at doing this after -current un-slushes. If there are any suggestions about other improvements, please follow-up to freebsd-arch. -- Brian Somers Tel: +1 604 484 6434 Mob: +1 604 315 1343 Sophos - security and control Web: www.sophos.com