From owner-freebsd-net@FreeBSD.ORG  Tue Aug 24 00:33:09 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 082641065693
	for <net@freebsd.org>; Tue, 24 Aug 2010 00:33:09 +0000 (UTC)
	(envelope-from qing.li@bluecoat.com)
Received: from whisker.bluecoat.com (whisker.bluecoat.com [216.52.23.28])
	by mx1.freebsd.org (Postfix) with ESMTP id 15FC88FC17
	for <net@freebsd.org>; Tue, 24 Aug 2010 00:33:08 +0000 (UTC)
Received: from bcs-mail03.internal.cacheflow.com ([10.2.2.95])
	by whisker.bluecoat.com (8.14.2/8.14.2) with ESMTP id o7O0MkBS020384;
	Mon, 23 Aug 2010 17:22:51 -0700 (PDT)
X-MimeOLE: Produced By Microsoft Exchange V6.5
Content-class: urn:content-classes:message
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Mon, 23 Aug 2010 17:22:29 -0700
Message-ID: <B583FBF374231F4A89607B4D08578A4307F1FC70@bcs-mail03.internal.cacheflow.com>
In-Reply-To: <alpine.LFD.2.00.1008240144350.12708@filebunker.xip.at>
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
Thread-Topic: funny ECMP
Thread-Index: ActDHsQE3FQ1Nnc5TT66L+z1AzXE3wAAzrhw
References: <alpine.LFD.2.00.1008230154280.29368@filebunker.xip.at>
	<alpine.LFD.2.00.1008240144350.12708@filebunker.xip.at>
From: "Li, Qing" <qing.li@bluecoat.com>
To: "Ingo Flaschberger" <if@xip.at>, <net@freebsd.org>
Cc: 
Subject: RE: funny ECMP
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Aug 2010 00:33:09 -0000

Hi,

>=20
> I have changed the route selection code of ecmp to
> balance only between routes of the same weight.
> (see attached file)
>=20


>
> As Qing Li mentioned months ago, there are problems with static routes
> and interfaces.
>=20

  Do you have the exact link to the email thread?=20
  There were no pending ECMP related issues since my last round of
commits
  as far as I can remember.

>
> Example 1:
> ifconfig em1 alias 10.13.13.90/24
>  	ping 10.13.13.95 ok
> route add 10.13.13.0/24 10.11.11.1 -weight 2
>  	ping 10.13.13.95 broken (arpresolve: can't allocate llinfo for
>  				10.13.13.95)
>=20

  Could you please explain a bit on exactly what you try to=20
  accomplish here with this configuration?

>=20
> deleting the last static multipath routes seems to affect?, destroy?
> the interface route.
> system crashes in:
> /usr/src/sys/net/route.c:370
>          rn =3D rnh->rnh_matchaddr(dst, rnh);
>          if (rn && ((rn->rn_flags & RNF_ROOT) =3D=3D 0)) {
>                  newrt =3D rt =3D RNTORT(rn);
> here ->         RT_LOCK(newrt);
>                  RT_ADDREF(newrt);
>                  if (needlock)
>=20

  I will take a look.

  -- Qing