From owner-freebsd-ports@FreeBSD.ORG Wed Dec 8 22:19:51 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A31AC106566B for ; Wed, 8 Dec 2010 22:19:51 +0000 (UTC) (envelope-from corky1951@comcast.net) Received: from qmta15.emeryville.ca.mail.comcast.net (qmta15.emeryville.ca.mail.comcast.net [76.96.27.228]) by mx1.freebsd.org (Postfix) with ESMTP id 891C48FC14 for ; Wed, 8 Dec 2010 22:19:51 +0000 (UTC) Received: from omta11.emeryville.ca.mail.comcast.net ([76.96.30.36]) by qmta15.emeryville.ca.mail.comcast.net with comcast id ggeD1f0020mlR8UAFmKrmU; Wed, 08 Dec 2010 22:19:51 +0000 Received: from comcast.net ([98.203.142.76]) by omta11.emeryville.ca.mail.comcast.net with comcast id gmKf1f0021f6R9u8XmKfLZ; Wed, 08 Dec 2010 22:19:45 +0000 Received: by comcast.net (sSMTP sendmail emulation); Wed, 08 Dec 2010 14:19:37 -0800 Date: Wed, 8 Dec 2010 14:19:37 -0800 From: Charlie Kester To: freebsd-ports@freebsd.org Message-ID: <20101208221936.GE11485@comcast.net> Mail-Followup-To: freebsd-ports@freebsd.org References: <20101207022753.GB5042@comcast.net> <4CFEDAB5.5030309@kc8onw.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Mailer: Mutt 1.5.20 X-Composer: Vim 7.2 User-Agent: Mutt/1.5.20 (2009-06-14) Subject: Re: failed configure of multimedia/handbrake X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Dec 2010 22:19:51 -0000 On Wed 08 Dec 2010 at 09:22:40 PST Ade Lovett wrote: > >On Dec 07, 2010, at 19:09 , Jonathan wrote: >> ${PATCH_WRKSRC} and $$file from ${LIBTOOLFILES} have the full path to >> the target file which when combined causes the not found error. I'm >> guessing this has something to do with the recent autotools changes >> so I'm cc'ing ade@ > >The port Makefile is incorrect. LIBTOOLFILES should be set (if >necessary) to a relative path, not an absolute one. > >grep -R LIBTOOLFILES /usr/ports will show you all the ports that >do this correctly -- the most recent autotools changes were >essentially a null-op to massively reduce tree-diffs on upgrades of >autoconf/automake/libtool > Thanks Ade! I can confirm that removing the reference to ${WRKSRC} on the LIBTOOLFILES line fixes the issue I'd been seeing. The handbrake port is unmaintained, and I don't see a PR with this fix. Shall I submit one, or is it already being handled?