Date: Sat, 5 Oct 2013 19:23:08 GMT From: Jason Unovitch <jason.unovitch@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/182711: [patch] net/serviio fails to install or upgrade without requiring human intervention to copy -dist config files Message-ID: <201310051923.r95JN8om040832@oldred.freebsd.org> Resent-Message-ID: <201310051930.r95JU0PH020534@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 182711 >Category: ports >Synopsis: [patch] net/serviio fails to install or upgrade without requiring human intervention to copy -dist config files >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Oct 05 19:30:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Jason Unovitch >Release: FreeBSD 9.2-RELEASE >Organization: N/A >Environment: FreeBSD xts-bsd 9.2-RELEASE FreeBSD 9.2-RELEASE #0 r255898: Thu Sep 26 22:50:31 UTC 2013 root@bake.isc.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 >Description: net/serviio's current pkg-plist installs *.dist.properties configuration files upon installation. The administrator must manually copy the distributed config files over so that Serviio can start. Upon a future `pkg upgrade` the files get removed and don't get re-installed, requiring administrator attention once again to replace the files. Serviio's pkg-plist should account for putting default configuration files in place. >How-To-Repeat: Install or upgrade net/serviio. It will need manual attention each time. >Fix: Fix the pkg-plist to place default config files in place in a similar manner to what is in the attached patch submission. Patch attached with submission follows: --- /root/old-serviio-pkg-plist 2013-10-04 22:33:36.000000000 +0000 +++ /usr/ports/net/serviio/pkg-plist 2013-10-04 22:18:54.000000000 +0000 @@ -41,6 +41,10 @@ @unexec cmp %D/%%ETCDIR%%/profiles.xml %D/%%ETCDIR%%/profiles.dist.xml && rm -f %D/%%ETCDIR%%/profiles.xml || echo Modified profiles.xml remains in %D/%%ETCDIR%% @unexec cmp %D/%%ETCDIR%%/log4j.xml %D/%%ETCDIR%%/log4j.dist.xml && rm -f %D/%%ETCDIR%%/log4j.xml || echo Modified log4j.xml remains in %D/%%ETCDIR%% @unexec cmp %D/%%ETCDIR%%/console-log4j.properties %D/%%ETCDIR%%/console-log4j.dist.properties && rm -f %D/%%ETCDIR%%/console-log4j.properties || echo Modified console-log4j.properties remains in %D/%%ETCDIR%% +@exec [ -f %D/%%ETCDIR%%/application-profiles.xml ] || cp -v %D/%%ETCDIR%%/application-profiles.dist.xml %D/%%ETCDIR%%/application-profiles.xml +@exec [ -f %D/%%ETCDIR%%/profiles.xml ] || cp -v %D/%%ETCDIR%%/profiles.dist.xml %D/%%ETCDIR%%/profiles.xml +@exec [ -f %D/%%ETCDIR%%/log4j.xml ] || cp -v %D/%%ETCDIR%%/log4j.dist.xml %D/%%ETCDIR%%/log4j.xml +@exec [ -f %D/%%ETCDIR%%/console-log4j.properties ] || cp -v %D/%%ETCDIR%%/console-log4j.dist.properties %D/%%ETCDIR%%/console-log4j.properties %%ETCDIR%%/profiles.dist.xml %%ETCDIR%%/log4j.dist.xml %%ETCDIR%%/application-profiles.dist.xml >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201310051923.r95JN8om040832>