From owner-svn-ports-all@freebsd.org Sat Jun 15 09:14:22 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7812115C18C1; Sat, 15 Jun 2019 09:14:22 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (hamza.pair.com [209.68.5.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 126676E086; Sat, 15 Jun 2019 09:14:21 +0000 (UTC) (envelope-from gerald@pfeifer.com) Received: from hamza.pair.com (localhost [127.0.0.1]) by hamza.pair.com (Postfix) with ESMTP id 9315C33FEA; Sat, 15 Jun 2019 05:14:20 -0400 (EDT) Received: from anthias (unknown [46.183.103.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by hamza.pair.com (Postfix) with ESMTPSA id B288A33FE9; Sat, 15 Jun 2019 05:14:18 -0400 (EDT) Date: Sat, 15 Jun 2019 11:14:08 +0200 (CEST) From: Gerald Pfeifer To: Piotr Kubaj cc: Mark Linimon , Alexey Dokuchaev , Cy Schubert , "Jason W. Bacon" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r504198 - head/Mk In-Reply-To: <20190615084354.GA33091@ThinkPad-X200.g.anongoth.pl> Message-ID: References: <201906141610.x5EGAdnN049103@repo.freebsd.org> <20190614165425.GA42674@FreeBSD.org> <8BDC3B40-7FEA-46EA-AE7C-A3C266F6978F@cschubert.com> <20190614175822.GA3336@FreeBSD.org> <20190615061345.GA20346@lonesome.com> <20190615084354.GA33091@ThinkPad-X200.g.anongoth.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 126676E086 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jun 2019 09:14:22 -0000 On Sat, 15 Jun 2019, Piotr Kubaj wrote: > In my opinion, there are not many ports that have USE_GCC=any specified. True, it's only 58 for USE_GCC=any versus 112 for USE_GCC=yes. Still 58 ports that won't be tested with the compiler they are (trying to be) built with on powerpc64. > Most ports just need USES=compiler:*. Yes, and that's where we should take action as well. For example, Mk/Uses/compiler.mk has .if ${_COMPILER_ARGS:Mopenmp} .if ${COMPILER_TYPE} == clang USE_GCC= yes CHOSEN_COMPILER_TYPE= gcc .endif .endif which means that anyone asking for compiler:openmp gets GCC 4.2, unless I'm missing something. Calling that a disservice is a euphemism. Plus r504153 that jwb@ had to make to biology/ncbi-blast+ as a follow-up to his recent update is a perfect example of the disservice that using GCC 4.2 by default on powerpc64 provides to its users: # Force newer GCC on platforms using GCC 4.2 as base .if ${CHOSEN_COMPILER_TYPE} == gcc USE_GCC= yes .endif This confirms my point that USE_GCC=any or what is practically equivalent in compiler.mk should be converted to USE_GCC=yes. Better for our users, better for our maintainers, and more consistency across platforms. Gerald