Date: Fri, 14 Jun 2013 12:00:40 -0300 From: William Grzybowski <william88@gmail.com> To: Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org> Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev <danfe@freebsd.org>, Eitan Adler <eadler@freebsd.org>, svn-ports-all@freebsd.org, William Grzybowski <wg@freebsd.org>, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r320832 - head/net-mgmt/bandwidthd Message-ID: <CAHtVNLPHf3WfW6hQ82w5kLKnt2fmMbOzDqV16O7Rh-FsWX40AQ@mail.gmail.com> In-Reply-To: <CAMHz58QEyobAZW=b7LDtRjHvNy4YqmCW-ObgN498X4YPw1B=DQ@mail.gmail.com> References: <201306131905.r5DJ5Scv074032@svn.freebsd.org> <CAF6rxgnv9ntqAPAXCgW=9kXC-AwHMHLTpEr%2B3S_McF=4-2bbSw@mail.gmail.com> <20130614065523.GA98995@FreeBSD.org> <CAMHz58QEyobAZW=b7LDtRjHvNy4YqmCW-ObgN498X4YPw1B=DQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 14, 2013 at 11:56 AM, Sunpoet Po-Chuan Hsieh
<sunpoet@freebsd.org> wrote:
> Try this (cited from lang/v8/Makefile)
>
> .if ${CC:T:Mclang} == "clang" || ${CXX:T:Mclang++} == "clang++" ||
> ${OSVERSION} >= 1000024
> ...
> .endif
That won't work, CC = "cc" in 10-CURRENT.
One should use "cc -v" + grep to find out whether it is clang or cc.
But I guess you're missing the point, there isn't a single issue here.
All is resolved.
Thanks
> On Fri, Jun 14, 2013 at 2:55 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
>>
>> On Thu, Jun 13, 2013 at 11:18:28PM +0200, Eitan Adler wrote:
>> > On Thu, Jun 13, 2013 at 9:05 PM, William Grzybowski <wg@freebsd.org>
>> > wrote:
>> >
>> > > -.if ${CC} == "clang"
>> >
>> > Thank you for changing this. FWIW if you *do* need to detect clang
>> > this check is incorrect.
>> >
>> > The idiom ${CC:T:Mclang} == "clang") is required in order to allow
>> > absolute paths, etc.
>>
>> Well, these checks are obsolete on -CURRENT where Clang is installed as
>> default compiler (cc).
>>
>> ./danfe
>
>
>
>
> --
> Sunpoet Po-Chuan Hsieh <sunpoet at sunpoet.net> <sunpoet at FreeBSD.org>
> 4096R/CC57E36B 8AD8 68F2 7D2B 0A10 7E9B 8CC0 DC44 247E CC57 E36B
> http://people.FreeBSD.org/~sunpoet/pgpkeys.txt
--
William Grzybowski
------------------------------------------
Curitiba/PR - Brasil
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHtVNLPHf3WfW6hQ82w5kLKnt2fmMbOzDqV16O7Rh-FsWX40AQ>