Date: Wed, 9 Apr 2014 14:41:31 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Mateusz Guzik <mjguzik@gmail.com> Cc: freebsd-hackers@freebsd.org, Eduardo Morras <emorrasg@yahoo.es> Subject: Re: pipe() resource exhaustion Message-ID: <20140409114131.GJ21331@kib.kiev.ua> In-Reply-To: <20140409113957.GB17650@dft-labs.eu> References: <lhu0jv$r6n$1@ger.gmane.org> <ab57e60fcc1c1438fcca500e3c594d35@mail.feld.me> <20140408130206.e75f3bf6c6df28b6e4839e70@yahoo.es> <20140408121222.GB30326@dft-labs.eu> <20140408123827.GW21331@kib.kiev.ua> <20140408130727.GA11363@dft-labs.eu> <20140408132442.GZ21331@kib.kiev.ua> <20140409111654.GA17650@dft-labs.eu> <20140409112627.GI21331@kib.kiev.ua> <20140409113957.GB17650@dft-labs.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Wed, Apr 09, 2014 at 01:39:57PM +0200, Mateusz Guzik wrote:
> On Wed, Apr 09, 2014 at 02:26:27PM +0300, Konstantin Belousov wrote:
> > > if (backing) {
> > > + /*
> > > + * Note that these functions can fail, but we ignore
> > > + * the error as it is not fatal and could be provoked
> > > + * by users.
> > > + */
> > It would be benefitial to add some more details on the way to provoke the
> > failure. Note in the comment that creating too much pipes would exhaust
> > pipe map and we fall back to the buffer pipe creation there, which still
> > work correctly, albeit slow.
> >
>
> How about:
>
> Note that these functions can fail if pipe map is exhausted (as a result
> of too many pipes created), but we ignore the error as it is not fatal
> and could be provoked by unprivileged users. The only consequence is worse
> performance with given pipe.
Ok.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)
iQIcBAEBAgAGBQJTRTHrAAoJEJDCuSvBvK1BUkgP/RaaBpu0dswBiovm8tSnA+ZD
32Cfms82IaJnY/X30JqYNIUyQT7uUMDo1yI6Ij1bnC/dJBbSrjIlUud6gBJebXbA
28qUUmZ100lhKj9y+Zt9dGpRXP11atuX9VgboqTpeE/e3S6Al1oSbKu0qPNh1Ggt
Cdbe1to1/heDxNcCLVOqlmfSnnfMtsTF5wicnmSdnbt839IBCRpVgndm8ErvCrW2
VVFATL+Z4Qwnk3rhlfnDJncF3fLZGF8ayPQRBtI3jo3O/fR5ETqidsvu1Fq3gOFS
u7qNXcMk3c/zvRPu7pc6ZVTu5Up3HkZ+iJtJo8nBw+DofnfFzi3mEHJJqjw/lFaS
7SpHaSUaGzFSdmG7irWmG19yV4a49STu7+3n7wyJMcqI6djf/NUaytjjSArqnsIk
rLTuv5CC3PwfNckGaq3SRLo+KKOyExb9qeBm8xypXoL0u1L+dcB7jW37ItUwEkgV
ifdPDQSW+OmPIStvufyF077LIppxAoYU8wgiyvrV5r3+qQofKVI15CLhbw6yAEEt
g8jw3mWohzS0WcMZRfJK65MZ1K0xATgpAYDlWpe49AR7PZRCPfpXdym0bNpG72SY
uPlK/9HZrGw6dqS7EQ2DIEN7qkwd13J8nFuGXJ75dO0ee5oFqMyQv5hzcz1hUfoB
3FyJeiyzfrYSf0vcnOnD
=0/Fo
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140409114131.GJ21331>