From owner-freebsd-audit Tue Jun 4 19:15:59 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id 7524B37B401; Tue, 4 Jun 2002 19:15:56 -0700 (PDT) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.12.1/8.12.1) with ESMTP id g552FqI8084548; Tue, 4 Jun 2002 22:15:52 -0400 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <200206050110.g551Alpu020379@xerxes.courtesan.com> References: <20020605083335.T5376-100000@gamplex.bde.org> <200206050110.g551Alpu020379@xerxes.courtesan.com> Date: Tue, 4 Jun 2002 22:15:51 -0400 To: "Todd C. Miller" From: Garance A Drosihn Subject: Re: [PATCH] making dump EINTR resistant Cc: Bruce Evans , Alexander Leidinger , audit@FreeBSD.ORG Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: MIMEDefang 2.3 (www dot roaringpenguin dot com slash mimedefang) Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 7:10 PM -0600 6/4/02, Todd C. Miller wrote: >In message > so spake Garance A Drosihn (drosih): > >> Would it be acceptable to add EINTR-type checks to freebsd-ish >> code? There are some sections of lpr/lpd which do not work >> right when compiled on other platforms, unless I add EINTR >> checks at the right places. > >It would probably be better to just make the code in question to >just use sigaction() if you are concerned about portability. That >way you get consistent handling of syscall restarts. > >Alternately, you could #define signal to bsd_signal when compiling >on non-BSD platforms. That is not quite as portable though. Ah. Actually I also wrote updates to use sigaction(), but I did that sometime after I had added the EINTR's around various system routines. It sounds like I shouldn't need the EINTR's anymore, but I just didn't realize it. I'll try going that route instead. That sounds much better. Thanks. (I'm still trying to unravel all the various updates I've added to lpr at RPI over the years...) -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message