From nobody Sun Jul 12 15:43:42 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gyqcB6kR6z6lWyp for ; Sun, 12 Jul 2026 15:43:54 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gyqcB3jK2z45XF for ; Sun, 12 Jul 2026 15:43:54 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-92e7c6ec9dbso93906785a.0 for ; Sun, 12 Jul 2026 08:43:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1783871033; cv=none; d=google.com; s=arc-20260327; b=h9OwQWYBFnZ7oBeNQh7X/9KtH1A0BzbptN9KLWWuyh6KMA+RDrkLsVL/O8G3uQEAwC QMyrvqVRbHJ3KoFFxeS5Fnsn/ut5LP4Xyni9LCNOS4nWVDKFJTD+dXcoTXa+X1T6YHWa +J4343/g717B+6FWrtjKCDdh7KbHGQoXNvVtQp32QZ5jn3M5Ri6zWnK213arb7SYGDxL +COQ+vLfDZE9g9YY57tryXN/Dx0AHtMHLG1xxFs0aO4c/RCA5v3AUdykLVyD5a/voUUq UV3t2nv9KtlsR2kXrnIzkaWxLU/Tw7yL0pOj3OQCQLgf9dw6GCVL6RL4W+i5/ZFMLCaO w/uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version; bh=O3hyztXfUa7TAfry2nTzzCk/2Uhi6gdoxrh5qQqfmgY=; fh=BZgn/GR6KGS+eFzRTFWXx9NZFQp7QOG3Pisv9rEOQ+0=; b=FBsmSlPAM/IWgXscNm2vLahBjESGCzT3BE0G9G6Um7FzCI6yeWsEEObsFrrLLrYGu6 ODN+W7P6+NR716BNNVexD6xUCx30aAyOvX9bQTGK5md5gq+FH46Sl3Va1iugT1+GlbAq WCMWS4a7MmgF+QhTQ7+3e+RLG8Rf2+gVMi4Z/BfGOao6teQJd9Cm4ijBCreFlvIzS6GY tYaN9CGu9bMbSoGMPIWZJN+GA4QiDmKwdsD5yMHivUy3gFpkf7CbURKm4p6Yzw2Az11Q vrinCQUj3gQGtNZJAEIte6pxINnUbvFVGrKTJNkmoeU+WHUGp0Tw6BJk4c13psAnDwcW uyEw==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783871033; x=1784475833; h=content-type:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=O3hyztXfUa7TAfry2nTzzCk/2Uhi6gdoxrh5qQqfmgY=; b=fWFEM9I38j9Tjr5za4y6HqHBDDpNSKZaoNTK1jGFbLOWsmjgbjtjazWGJ1NE7e1+yW 8LF5qhiUN2IzwqOdhhZ/iNgiZBAIRmH1o6Wjzj7jDlgjIAwg7OJqSLP/4kb35mLoRsAU XLGbfaNVQ0nlw1zKkwHV2r2G6i6xIAculoR4+KLTHXrHg/EBp1Y/Dq3L5uHuPsQGRGV0 Xy2f4xhq5vOONlxSnGfSJ932QBap76XzFDx5bm1RJqEmXqeAAYXDMorw2+X6OzuKvLA8 n1boYKj3QjZndRid0kpBE7kbFCK2C+fTq50Npq8FnxoYYc4gglWzkzCuQUK5ZX3zK55q qr0w== X-Forwarded-Encrypted: i=1; AHgh+RqdeawK01TZ3auGosvu7U3bCGpGgjda6eDC8uxzXPQ5CZWr2UjUz58MfTvskJ43KrsSN5EfA8DTFCeHbhX4b68P03P6@freebsd.org X-Gm-Message-State: AOJu0YxXHa9WDd2z4ZJv/E7qexViaGtHNI8CfLumyvmcGRWcv4n6+UY6 Khk5V2WchuF+Fxy4xp4xSyc/8gmnzHj7/2A08VY62zzXZ2q3D+PuRrhOi1GxHKqczbioa/QWj3w nf8BPJwthjWwlndXxkjgcFzSPqYkHFQM= X-Gm-Gg: AfdE7cnXGOBVgpzLdSy3JwE/FbybXueVc67lX0iH9BCVMXnvrNTrwQzP7p9vixd2GXL ZSioORcBhjnqtnHve0lln0o1qOdL2h0S1hX+77nHAKX7n25mWxl6oC6IREdAoPrzYANy5PQlJIT gyzGeVg2aCvOYyTlsvdE+sCWUBxI4YruTK18Kcoj8mBgp4fKPjH9j1hcHHJ2Hyw+J5s+rNg7jTo FfrqOYQY2x1/Pl8p5EryEcRBago4SnL7oAUThKKjpmrI2XNmaqXc3x121uV4jZCTT1fwf2beLtE H8AUkeUxitxZLxamCuKbjtVf3fzi1+ChDC98J/YbziYm6Ww7g/i9RtavKy7i60N4c2CbLwqhAkO fT2CV5UbCqEcBhYdsbnSjttJp3xuiRtdq+9yjrtBdA/xhzMc= X-Received: by 2002:a05:620a:608a:b0:92e:8405:7ae8 with SMTP id af79cd13be357-92ef2b3888emr592813685a.4.1783871033519; Sun, 12 Jul 2026 08:43:53 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 References: <6a1008a0.3f79c.1d455f29@gitrepo.freebsd.org> <49761290-2d6c-403f-acdd-48b5b536804c@FreeBSD.org> In-Reply-To: <49761290-2d6c-403f-acdd-48b5b536804c@FreeBSD.org> From: Adrian Chadd Date: Sun, 12 Jul 2026 08:43:42 -0700 X-Gm-Features: AUfX_mxWciTEb_ANI7QFMI3kHQlcKZY31KWRMOVv_hof4xOKfZZl74aRc9-C5LE Message-ID: Subject: Re: git: 28d85db46b48 - main - xhci: Do not drop and add bits in xhci To: Kyle Evans Cc: ShengYi Hung , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Vladimir Kondratyev Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4gyqcB3jK2z45XF X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Spamd-Bar: ---- On Sat, 11 Jul 2026 at 20:21, Kyle Evans wrote: > > On 5/22/26 02:41, ShengYi Hung wrote: > > The branch main has been updated by aokblast: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=28d85db46b484589e2ee74cf4b270db066821de1 > Hi, > > This patch reliably fixes a bug I've been trying to track down in a u2f(4) patch > that I've been testing, and I'm wondering if you can help connect the dots. I > have a Solo2 u2f(4) key that I find will inconsistently desync (for other reasons) > and hang, and the solution for *that* is to release this NOT_YET block[0] in > u2f_dtor(). > > The problem I was hunting down is that doing so subsequently broke my Yubikey in a > way that this patch alone seems to fix. It would hang on every other ssh attempt, as > long as we issued usbd_transfer_stop on our interrupt endpoints upon last-close. It > was known to work with uhid(4) reliably which issues a stop as well, and that's the > thing I can't really explain. Is there something that uhid(4) / usb_dev.c is doing > that might have accidentally worked around this? > > This was the only commit that looked relevant in the fast-forward I did for my latest > round of testing from 9c18d55a768a3 to 707ee7ff952c5, and reverting just this patch > reliably re-introduces the problem I was having with the Yubikey. > My guess is the yubikey device firmware pays attention to this bit and the state is only reset when the state cycles through STOP. If you're curious, try comparing usbdump captures before/after the fix and look for explicit differences in things and then guess what the firmware is doing. -adrian