From owner-svn-ports-head@freebsd.org  Sun Sep 23 12:15:26 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3EB8C108D952;
 Sun, 23 Sep 2018 12:15:26 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id EDA07743E4;
 Sun, 23 Sep 2018 12:15:25 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id E57768873; Sun, 23 Sep 2018 12:15:25 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Po-Chuan Hsieh <sunpoet@freebsd.org>
Cc: amdmi3@freebsd.org, svn-ports-head@freebsd.org,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject: Re: svn commit: r480462 - head/devel/p5-DateTime-Format-ICal
References: <201809230908.w8N98RkZ018259@repo.freebsd.org>
 <CAMHz58Q6ME1k7fPyrSmtmnM0zE6jJc==xE1JwUdpV7hOyzY+Rw@mail.gmail.com>
Date: Sun, 23 Sep 2018 14:15:22 +0200
In-Reply-To: <CAMHz58Q6ME1k7fPyrSmtmnM0zE6jJc==xE1JwUdpV7hOyzY+Rw@mail.gmail.com>
 (Po-Chuan Hsieh's message of "Sun, 23 Sep 2018 17:24:46 +0800")
Message-ID: <worc-o1et-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Sep 2018 12:15:26 -0000

Po-Chuan Hsieh <sunpoet@freebsd.org> writes:

> On Sun, Sep 23, 2018 at 5:08 PM Dmitry Marakasov <amdmi3@freebsd.org> wrote:
>
>> Author: amdmi3
>> Date: Sun Sep 23 09:08:27 2018
>> New Revision: 480462
>> URL: https://svnweb.freebsd.org/changeset/ports/480462
>>
>> Log:
>>   - Add LICENSE
>>   - Fix depends
>>
>
> I did not see any dependency change in this commit.

Before this commit BUILD_DEPENDS had lang/perl5* listed more than once. ;)

> According to mat's commit (r474242), the original one is preferred.

Porter's Handbook recommends MY_DEPENDS, not BUILD_DEPENDS=${RUN_DEPENDS}.
If you treat PH as rulebook (like portmgr often likes to do) then mat's
commit was incorrect as well.

https://www.freebsd.org/doc/en/books/porters-handbook/makefile-depend.html#makefile-run_depends

Unfortunately, Porter's Handbook fails short of explaining why := is wrong.
Even if a port uses RUN_DEPENDS:=${BUILD_DEPENDS} then Mk/* can still append
to RUN_DEPENDS but anything appended to BUILD_DEPENDS doesn't propagate to
RUN_DEPENDS which is intended. Not to mention, forbidding to use := in *_DEPENDS
but not anywhere else seems odd.