From owner-cvs-src@FreeBSD.ORG Tue Feb 12 22:01:04 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3E5EC16A421; Tue, 12 Feb 2008 22:01:04 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from sippysoft.com (gk1.360sip.com [72.236.70.240]) by mx1.freebsd.org (Postfix) with ESMTP id ECCAD13C455; Tue, 12 Feb 2008 22:01:03 +0000 (UTC) (envelope-from sobomax@FreeBSD.org) Received: from [192.168.0.3] ([204.244.149.125]) (authenticated bits=0) by sippysoft.com (8.13.8/8.13.8) with ESMTP id m1CLi0ur024407 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 12 Feb 2008 13:44:01 -0800 (PST) (envelope-from sobomax@FreeBSD.org) Message-ID: <47B212C2.2040005@FreeBSD.org> Date: Tue, 12 Feb 2008 13:42:26 -0800 From: Maxim Sobolev Organization: Sippy Software, Inc. User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: "Christian S.J. Peron" References: <200802122055.m1CKt4oL044057@repoman.freebsd.org> In-Reply-To: <200802122055.m1CKt4oL044057@repoman.freebsd.org> Content-Type: text/plain; charset=KOI8-U; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys ipc.h shm.h src/sys/kern sysv_shm.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2008 22:01:04 -0000 Christian S.J. Peron wrote: > csjp 2008-02-12 20:55:04 UTC > > FreeBSD src repository > > Modified files: > sys/sys ipc.h shm.h > sys/kern sysv_shm.c > Log: > Make sure we restrict Linux only IPC calls from being executed > through the FreeBSD ABI. IPC_INFO, SHM_INFO, SHM_STAT were added > specifically for Linux binary support. They are not documented > as being a part of the FreeBSD ABI, also, the structures necessary > for them have been hidden away from the users for a long time. > > Also, the Linux ABI layer uses it's own structures to populate the > responses back to the user to ensure that the ABI is consistent. > > I think there is a bit more separation work that needs to happen. > > Reviewed by: jhb > Discussed with: jhb > Discussed on: freebsd-arch@ (very briefly) > MFC after: 1 month Just curious why not make those functions available via FreeBSD API instead by properly advertising them in the documentation? From my completely ignorant point of view it should make it easier to port a software that has been created on Linux, which is always a Good Thing[tm]. -Maxim