From owner-freebsd-fs@FreeBSD.ORG Thu Oct 16 02:58:02 2014 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CCC71578 for ; Thu, 16 Oct 2014 02:58:02 +0000 (UTC) Received: from mail-wi0-x230.google.com (mail-wi0-x230.google.com [IPv6:2a00:1450:400c:c05::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 584FD92B for ; Thu, 16 Oct 2014 02:58:02 +0000 (UTC) Received: by mail-wi0-f176.google.com with SMTP id hi2so282453wib.3 for ; Wed, 15 Oct 2014 19:58:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=tnwEAb2ZW1jLz61MwN4rb/AzRrb04LqlVtAni0Fsy+4=; b=zosbscQMnQpfoJR6+mtgj4wbIaGSwDNI+QPA81Lb1Flb2HbAPKbn3zjQw0ZkyxOxZR Qum8oa6IbqocSGb363c9OkBCqNMn/mR34ORXMGMVuqUI8nvaayT+Ikfa4nQvwOZak5rJ XZtv/bA3uSMY3pmSWzAz008y5xgZK8vZQxz3SbkQ+2h2q9cRdsqoOq267tG14sxi8EUI 3fGPwuCQdY8NFuBv4TKpTZ7BNlfVYULe2mS5gm8snTOW4tYuJBjvEMPU2EsyCi66lcx2 nHzU6z9sYfluumlGpN6Hg3dLCm7KRgbfbnMII6QuNzwiuhoDaZbSDtS51iINrcGaDSdh dNBA== MIME-Version: 1.0 X-Received: by 10.180.88.162 with SMTP id bh2mr1877646wib.77.1413428280498; Wed, 15 Oct 2014 19:58:00 -0700 (PDT) Received: by 10.216.159.193 with HTTP; Wed, 15 Oct 2014 19:58:00 -0700 (PDT) Reply-To: araujo@FreeBSD.org In-Reply-To: References: <1865571459.65576954.1413416765814.JavaMail.root@uoguelph.ca> Date: Thu, 16 Oct 2014 10:58:00 +0800 Message-ID: Subject: Re: [PATCH] disable nfsd (NFSv4) nobody/nogroup check From: Marcelo Araujo To: Rick Macklem Content-Type: multipart/mixed; boundary=f46d04426c58951a010505816ad2 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "freebsd-fs@freebsd.org" X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Oct 2014 02:58:02 -0000 --f46d04426c58951a010505816ad2 Content-Type: text/plain; charset=UTF-8 2014-10-16 10:42 GMT+08:00 Marcelo Araujo : > > > 2014-10-16 7:46 GMT+08:00 Rick Macklem : > >> Marcelo Araujo wrote: >> > >> > Hello Ronald and Blot, >> > >> > >> > >> > Here is the patch with a small rework. I consider Ronaldo's comments >> > as well as I just change a bit the code style. >> > >> > >> > If you guys agree with the patch, I will commit it today. >> > >> Looks fine to me. >> > > Thanks Rick! Committed; I will do the MFC after two weeks if you have no > objections. > > https://svnweb.freebsd.org/base?view=revision&revision=273159 > > >> > >> > Note: About the disable_utf8 that Rick has mention, I will rework >> > that part later to make it as enable_utf8 instead of disable_utf8. >> > >> If you do change this one, try to include something in the description >> string w.r.t. RFC-3530 requires it to be enabled. >> >> Thanks, rick >> >> > Rick, here is a patch that renames the disable_utf8 to enable_utf8 and as > per your request, I have changed the description of the sysctl(8) as well. > Let me know if the change looks good for you as well as the description. > > > > Ouch, I forgot to attach the patch, spotted by kevlo@ via Skype :_) Best Regards, -- -- Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_) --f46d04426c58951a010505816ad2 Content-Type: text/plain; charset=US-ASCII; name="nfsd_utf8.diff" Content-Disposition: attachment; filename="nfsd_utf8.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i1biosbw0 SW5kZXg6IHN5cy9mcy9uZnNzZXJ2ZXIvbmZzX25mc2RzdWJzLmMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gc3lz L2ZzL25mc3NlcnZlci9uZnNfbmZzZHN1YnMuYwkocmV2aXNpb24gMjczMTU5KQorKysgc3lzL2Zz L25mc3NlcnZlci9uZnNfbmZzZHN1YnMuYwkod29ya2luZyBjb3B5KQpAQCAtNjEsMTAgKzYxLDEw IEBACiAKIFNZU0NUTF9ERUNMKF92ZnNfbmZzZCk7CiAKLXN0YXRpYyBpbnQJZGlzYWJsZV9jaGVj a3V0ZjggPSAwOwotU1lTQ1RMX0lOVChfdmZzX25mc2QsIE9JRF9BVVRPLCBkaXNhYmxlX2NoZWNr dXRmOCwgQ1RMRkxBR19SVywKLSAgICAmZGlzYWJsZV9jaGVja3V0ZjgsIDAsCi0gICAgIkRpc2Fi bGUgdGhlIE5GU3Y0IGNoZWNrIGZvciBhIFVURjggY29tcGxpYW50IG5hbWUiKTsKK3N0YXRpYyBp bnQJZW5hYmxlX2NoZWNrdXRmOCA9IDE7CitTWVNDVExfSU5UKF92ZnNfbmZzZCwgT0lEX0FVVE8s IGVuYWJsZV9jaGVja3V0ZjgsIENUTEZMQUdfUlcsCisgICAgJmVuYWJsZV9jaGVja3V0ZjgsIDAs CisgICAgIkVuYWJsZSB0aGUgTkZTdjQgY2hlY2sgZm9yIHRoZSBVVEY4IGNvbXBsaWFudCBuYW1l IHJlcXVpcmVkIGJ5IHJmYzM1MzAiKTsKIAogc3RhdGljIGludCAgICBlbmFibGVfbm9ib2R5Y2hl Y2sgPSAxOwogU1lTQ1RMX0lOVChfdmZzX25mc2QsIE9JRF9BVVRPLCBlbmFibGVfbm9ib2R5Y2hl Y2ssIENUTEZMQUdfUlcsCkBAIC0yMDA1LDcgKzIwMDUsNyBAQAogCQkgICAgZXJyb3IgPSAwOwog CQkgICAgZ290byBuZnNtb3V0OwogCQl9Ci0JCWlmIChkaXNhYmxlX2NoZWNrdXRmOCA9PSAwICYm CisJCWlmIChlbmFibGVfY2hlY2t1dGY4ID09IDEgJiYKIAkJICAgIG5mc3J2X2NoZWNrdXRmOCgo dV9pbnQ4X3QgKilidWZwLCBvdXRsZW4pKSB7CiAJCSAgICBuZC0+bmRfcmVwc3RhdCA9IE5GU0VS Ul9JTlZBTDsKIAkJICAgIGVycm9yID0gMDsK --f46d04426c58951a010505816ad2--